From 08afae27863e884d68937f76e5bb87bba171c5de Mon Sep 17 00:00:00 2001 From: Taneem Ibrahim Date: Tue, 18 Aug 2026 23:36:05 -0500 Subject: [PATCH] [ModelRunner v2] Enable MRV2 for pooling models by default (#48290) Signed-off-by: Taneem Ibrahim --- tests/models/language/pooling/test_colbert.py | 4 +-- tests/test_config.py | 29 +++++++++++++++++-- vllm/config/vllm.py | 3 -- 3 files changed, 28 insertions(+), 8 deletions(-) diff --git a/tests/models/language/pooling/test_colbert.py b/tests/models/language/pooling/test_colbert.py index dd4e1dea97..75323d54bf 100644 --- a/tests/models/language/pooling/test_colbert.py +++ b/tests/models/language/pooling/test_colbert.py @@ -323,8 +323,8 @@ class TestColbertSharedEngine: [ pytest.param("bert", True, id="bert-v2"), pytest.param("modernbert", True, id="modernbert-v2"), - pytest.param("jina", False, id="jina-v1"), - pytest.param("lfm2", False, id="lfm2-v1"), + pytest.param("jina", True, id="jina-v2"), + pytest.param("lfm2", True, id="lfm2-v2"), ], ) def test_colbert_hf_comparison(vllm_runner, monkeypatch, backend, use_v2): diff --git a/tests/test_config.py b/tests/test_config.py index a2797e5212..8560e4f334 100644 --- a/tests/test_config.py +++ b/tests/test_config.py @@ -344,13 +344,36 @@ def test_resolve_cudagraph_mode_adjusts_spec_decode_sizes_only_for_v1( ), ( SimpleNamespace( - model="Qwen/Qwen3-Embedding-0.6B", - architectures=["Qwen3ForCausalLM"], + model="sentence-transformers/all-MiniLM-L6-v2", + architectures=["BertModel"], runner_type="pooling", + is_multimodal_model=False, is_moe=False, is_quantized=False, ), - False, + True, + ), + ( + SimpleNamespace( + model="Qwen/Qwen3-Embedding-0.6B", + architectures=["Qwen3ForCausalLM"], + runner_type="pooling", + is_multimodal_model=False, + is_moe=False, + is_quantized=False, + ), + True, + ), + ( + SimpleNamespace( + model="TomoroAI/tomoro-colqwen3-embed-4b", + architectures=["ColQwen3"], + runner_type="pooling", + is_multimodal_model=True, + is_moe=False, + is_quantized=False, + ), + True, ), ], ) diff --git a/vllm/config/vllm.py b/vllm/config/vllm.py index ff93bed86f..cee60e99b6 100644 --- a/vllm/config/vllm.py +++ b/vllm/config/vllm.py @@ -676,9 +676,6 @@ class VllmConfig: if model_config is None: return False - if model_config.runner_type != "generate": - return False - architectures = getattr(model_config, "architectures", []) default_architectures = default_v2_model_runner_architectures() is_default_v2_architecture = any(