[Bugfix][KV Offload] Check cgroup memory before SHM allocation (#54014)
Signed-off-by: Alex <jihui.huang@daocloud.io> Signed-off-by: AlexHuang <alex.tech.lab@outlook.com> Signed-off-by: Alex <alex.tech.lab@outlook.com> Co-authored-by: OpenAI Codex <codex@openai.com> Co-authored-by: Itay Etelis <92247226+Etelis@users.noreply.github.com>
This commit is contained in:
co-authored by
OpenAI Codex
Itay Etelis
parent
e0301afb2a
commit
0f8fa53acf
@@ -694,14 +694,43 @@ def test_check_shm_free_space_raises_when_insufficient(tmp_path):
|
||||
|
||||
|
||||
def test_check_shm_free_space_passes_when_sufficient(tmp_path):
|
||||
with mock.patch.object(
|
||||
shm_broadcast.shutil, "disk_usage", return_value=_fake_disk_usage(512 << 20)
|
||||
with (
|
||||
mock.patch.object(
|
||||
shm_broadcast.shutil,
|
||||
"disk_usage",
|
||||
return_value=_fake_disk_usage(512 << 20),
|
||||
),
|
||||
mock.patch.object(shm_broadcast, "check_cgroup_memory_available"),
|
||||
):
|
||||
check_shm_free_space(240 << 20, shm_path=str(tmp_path))
|
||||
|
||||
|
||||
def test_check_shm_free_space_skipped_when_path_missing(tmp_path):
|
||||
check_shm_free_space(1 << 60, shm_path=str(tmp_path / "does-not-exist"))
|
||||
with mock.patch.object(shm_broadcast, "check_cgroup_memory_available"):
|
||||
check_shm_free_space(1 << 60, shm_path=str(tmp_path / "does-not-exist"))
|
||||
|
||||
|
||||
def test_check_shm_free_space_checks_cgroup(tmp_path):
|
||||
with (
|
||||
mock.patch.object(
|
||||
shm_broadcast.shutil,
|
||||
"disk_usage",
|
||||
return_value=_fake_disk_usage(512 << 20),
|
||||
),
|
||||
mock.patch.object(
|
||||
shm_broadcast, "check_cgroup_memory_available"
|
||||
) as check_cgroup,
|
||||
):
|
||||
check_shm_free_space(
|
||||
240 << 20,
|
||||
shm_path=str(tmp_path),
|
||||
allocation_name="SHM mmap",
|
||||
)
|
||||
|
||||
check_cgroup.assert_called_once_with(
|
||||
240 << 20,
|
||||
"SHM mmap",
|
||||
)
|
||||
|
||||
|
||||
def test_shm_ring_buffer_creation_checks_free_space():
|
||||
|
||||
@@ -0,0 +1,189 @@
|
||||
# SPDX-License-Identifier: Apache-2.0
|
||||
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project
|
||||
"""Cgroup memory readers and SHM allocation preflight checks."""
|
||||
|
||||
import sys
|
||||
from io import StringIO
|
||||
from unittest import mock
|
||||
|
||||
import pytest
|
||||
|
||||
from vllm.utils import cpu_resource_utils as cru
|
||||
from vllm.utils.mem_constants import GiB_bytes
|
||||
|
||||
_V2_LIMIT_PATH = "/sys/fs/cgroup/memory.max"
|
||||
_V2_USAGE_PATH = "/sys/fs/cgroup/memory.current"
|
||||
_V1_LIMIT_PATH = "/sys/fs/cgroup/memory/memory.limit_in_bytes"
|
||||
_V1_USAGE_PATH = "/sys/fs/cgroup/memory/memory.usage_in_bytes"
|
||||
|
||||
|
||||
@pytest.fixture(autouse=True)
|
||||
def _clear_cgroup_cache():
|
||||
cru.get_cgroup_memory_limit.cache_clear()
|
||||
yield
|
||||
cru.get_cgroup_memory_limit.cache_clear()
|
||||
|
||||
|
||||
def _stub_files(monkeypatch, files: dict):
|
||||
"""Stub ``open()`` for a fixed set of paths; ``None`` -> OSError."""
|
||||
real_open = open
|
||||
|
||||
def fake_open(path, *args, **kwargs):
|
||||
if path in files:
|
||||
content = files[path]
|
||||
if content is None:
|
||||
raise OSError(f"no such file: {path}")
|
||||
return StringIO(content)
|
||||
return real_open(path, *args, **kwargs)
|
||||
|
||||
monkeypatch.setattr("builtins.open", fake_open)
|
||||
|
||||
|
||||
def test_cgroup_v2_limit_and_usage(monkeypatch):
|
||||
monkeypatch.setattr(sys, "platform", "linux")
|
||||
_stub_files(
|
||||
monkeypatch,
|
||||
{
|
||||
_V2_LIMIT_PATH: f"{20 * GiB_bytes}\n",
|
||||
_V2_USAGE_PATH: f"{5 * GiB_bytes}\n",
|
||||
},
|
||||
)
|
||||
|
||||
assert cru.get_cgroup_memory_limit() == 20 * GiB_bytes
|
||||
assert cru.get_cgroup_memory_usage() == 5 * GiB_bytes
|
||||
|
||||
|
||||
def test_cgroup_v2_unlimited_falls_back_to_v1(monkeypatch):
|
||||
monkeypatch.setattr(sys, "platform", "linux")
|
||||
_stub_files(
|
||||
monkeypatch,
|
||||
{
|
||||
_V2_LIMIT_PATH: "max\n",
|
||||
_V1_LIMIT_PATH: f"{8 * GiB_bytes}\n",
|
||||
_V1_USAGE_PATH: f"{1 * GiB_bytes}\n",
|
||||
},
|
||||
)
|
||||
|
||||
assert cru.get_cgroup_memory_limit() == 8 * GiB_bytes
|
||||
assert cru.get_cgroup_memory_usage() == 1 * GiB_bytes
|
||||
|
||||
|
||||
def test_cgroup_v1_limit_and_usage(monkeypatch):
|
||||
monkeypatch.setattr(sys, "platform", "linux")
|
||||
_stub_files(
|
||||
monkeypatch,
|
||||
{
|
||||
_V2_LIMIT_PATH: None,
|
||||
_V1_LIMIT_PATH: f"{8 * GiB_bytes}\n",
|
||||
_V1_USAGE_PATH: f"{2 * GiB_bytes}\n",
|
||||
},
|
||||
)
|
||||
|
||||
assert cru.get_cgroup_memory_limit() == 8 * GiB_bytes
|
||||
assert cru.get_cgroup_memory_usage() == 2 * GiB_bytes
|
||||
|
||||
|
||||
def test_cgroup_v1_unlimited_sentinel_is_ignored(monkeypatch):
|
||||
"""An unlimited cgroup v1 sentinel must not be treated as a real limit."""
|
||||
monkeypatch.setattr(sys, "platform", "linux")
|
||||
_stub_files(
|
||||
monkeypatch,
|
||||
{_V2_LIMIT_PATH: None, _V1_LIMIT_PATH: f"{(1 << 63) - 1}\n"},
|
||||
)
|
||||
|
||||
assert cru.get_cgroup_memory_limit() is None
|
||||
assert cru.get_cgroup_memory_usage() is None
|
||||
|
||||
|
||||
def test_cgroup_no_limit_files_present(monkeypatch):
|
||||
monkeypatch.setattr(sys, "platform", "linux")
|
||||
_stub_files(monkeypatch, {_V2_LIMIT_PATH: None, _V1_LIMIT_PATH: None})
|
||||
|
||||
assert cru.get_cgroup_memory_limit() is None
|
||||
assert cru.get_cgroup_memory_usage() is None
|
||||
|
||||
|
||||
def test_cgroup_skipped_on_non_linux(monkeypatch):
|
||||
monkeypatch.setattr(sys, "platform", "darwin")
|
||||
_stub_files(monkeypatch, {_V2_LIMIT_PATH: f"{1 * GiB_bytes}\n"})
|
||||
|
||||
assert cru.get_cgroup_memory_limit() is None
|
||||
assert cru.get_cgroup_memory_usage() is None
|
||||
|
||||
|
||||
def test_cgroup_limit_is_cached_until_explicitly_cleared(monkeypatch):
|
||||
monkeypatch.setattr(sys, "platform", "linux")
|
||||
files = {
|
||||
_V2_LIMIT_PATH: f"{1 * GiB_bytes}\n",
|
||||
_V2_USAGE_PATH: f"{512 << 20}\n",
|
||||
}
|
||||
_stub_files(monkeypatch, files)
|
||||
|
||||
assert cru.get_cgroup_memory_limit() == 1 * GiB_bytes
|
||||
files[_V2_LIMIT_PATH] = f"{2 * GiB_bytes}\n"
|
||||
assert cru.get_cgroup_memory_limit() == 1 * GiB_bytes
|
||||
|
||||
cru.get_cgroup_memory_limit.cache_clear()
|
||||
assert cru.get_cgroup_memory_limit() == 2 * GiB_bytes
|
||||
|
||||
|
||||
def test_cgroup_usage_is_read_without_cache(monkeypatch):
|
||||
monkeypatch.setattr(sys, "platform", "linux")
|
||||
files = {
|
||||
_V2_LIMIT_PATH: f"{1 * GiB_bytes}\n",
|
||||
_V2_USAGE_PATH: f"{512 << 20}\n",
|
||||
}
|
||||
_stub_files(monkeypatch, files)
|
||||
|
||||
assert cru.get_cgroup_memory_usage() == 512 << 20
|
||||
files[_V2_USAGE_PATH] = f"{768 << 20}\n"
|
||||
assert cru.get_cgroup_memory_usage() == 768 << 20
|
||||
|
||||
|
||||
def test_check_cgroup_memory_available_warns_on_low_headroom(monkeypatch):
|
||||
monkeypatch.setattr(cru, "get_cgroup_memory_limit", lambda: 1 << 30)
|
||||
monkeypatch.setattr(cru, "get_cgroup_memory_usage", lambda: 512 << 20)
|
||||
|
||||
with (
|
||||
mock.patch.object(cru.logger, "debug") as log_debug,
|
||||
mock.patch.object(cru.logger, "warning") as log_warning,
|
||||
):
|
||||
cru.check_cgroup_memory_available(600 << 20, "mmap")
|
||||
|
||||
log_debug.assert_not_called()
|
||||
log_warning.assert_called_once()
|
||||
assert "current headroom is below" in log_warning.call_args.args[-1]
|
||||
|
||||
|
||||
def test_check_cgroup_memory_available_logs_success_at_debug(monkeypatch):
|
||||
monkeypatch.setattr(cru, "get_cgroup_memory_limit", lambda: 1 << 30)
|
||||
monkeypatch.setattr(cru, "get_cgroup_memory_usage", lambda: 512 << 20)
|
||||
|
||||
with (
|
||||
mock.patch.object(cru.logger, "debug") as log_debug,
|
||||
mock.patch.object(cru.logger, "warning") as log_warning,
|
||||
):
|
||||
cru.check_cgroup_memory_available(256 << 20, "mmap")
|
||||
|
||||
log_debug.assert_called_once()
|
||||
log_warning.assert_not_called()
|
||||
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
("limit", "usage"),
|
||||
[(None, 512 << 20), (1 << 30, None)],
|
||||
)
|
||||
def test_check_cgroup_memory_available_skips_without_snapshot(
|
||||
monkeypatch, limit, usage
|
||||
):
|
||||
monkeypatch.setattr(cru, "get_cgroup_memory_limit", lambda: limit)
|
||||
monkeypatch.setattr(cru, "get_cgroup_memory_usage", lambda: usage)
|
||||
|
||||
with (
|
||||
mock.patch.object(cru.logger, "debug") as log_debug,
|
||||
mock.patch.object(cru.logger, "warning") as log_warning,
|
||||
):
|
||||
cru.check_cgroup_memory_available(1 << 60, "mmap")
|
||||
|
||||
log_debug.assert_not_called()
|
||||
log_warning.assert_not_called()
|
||||
@@ -906,12 +906,13 @@ def test_insufficient_space_raises_clear_error(monkeypatch):
|
||||
monkeypatch.setattr(region.os, "open", mock_open)
|
||||
monkeypatch.setattr(region.os, "unlink", mock_unlink)
|
||||
monkeypatch.setattr(region.os, "close", mock_close)
|
||||
mock_check = MagicMock(
|
||||
side_effect=RuntimeError("Insufficient space in /dev/shm: 30 GB required.")
|
||||
)
|
||||
monkeypatch.setattr(
|
||||
region,
|
||||
"check_shm_free_space",
|
||||
lambda *a, **kw: (_ for _ in ()).throw(
|
||||
RuntimeError("Insufficient space in /dev/shm: 30 GB required.")
|
||||
),
|
||||
mock_check,
|
||||
)
|
||||
|
||||
with pytest.raises(RuntimeError, match="Insufficient space"):
|
||||
@@ -925,6 +926,10 @@ def test_insufficient_space_raises_clear_error(monkeypatch):
|
||||
|
||||
mock_unlink.assert_called_once_with(mmap_path)
|
||||
mock_close.assert_called_once_with(9999)
|
||||
mock_check.assert_called_once_with(
|
||||
4 * PAGE_SIZE,
|
||||
allocation_name="CPU KV offload shared region in /dev/shm",
|
||||
)
|
||||
|
||||
|
||||
def test_ftruncate_failure_cleans_up_creator(monkeypatch):
|
||||
|
||||
Reference in New Issue
Block a user