From 1b16f2ddc93751805fc19001323db93607570234 Mon Sep 17 00:00:00 2001 From: Rotem Shavitt Date: Thu, 28 May 2026 10:05:48 +0300 Subject: [PATCH] change name of fs_python secondary tier to fs. (#43600) Signed-off-by: Rotem Shavitt --- tests/v1/kv_connector/unit/test_offloading_connector.py | 4 ++-- tests/v1/kv_offload/test_fs_tier.py | 6 +++--- vllm/v1/kv_offload/tiering/factory.py | 2 +- vllm/v1/kv_offload/tiering/fs/thread_pool.py | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/v1/kv_connector/unit/test_offloading_connector.py b/tests/v1/kv_connector/unit/test_offloading_connector.py index 6665fcc089..d123cc520a 100644 --- a/tests/v1/kv_connector/unit/test_offloading_connector.py +++ b/tests/v1/kv_connector/unit/test_offloading_connector.py @@ -347,12 +347,12 @@ def test_tiering_offloading() -> None: def test_fs_tiering_offloading(tmp_path) -> None: """Tests OffloadingConnector with TieringOffloadingSpec - + fs_python secondary tier.""" + + fs secondary tier.""" extra_config: dict = { "cpu_bytes_to_use": 1 << 30, "block_size": 48, "spec_name": "TieringOffloadingSpec", - "secondary_tiers": [{"type": "fs_python", "root_dir": str(tmp_path)}], + "secondary_tiers": [{"type": "fs", "root_dir": str(tmp_path)}], } kv_transfer_config = KVTransferConfig( kv_connector="OffloadingConnector", diff --git a/tests/v1/kv_offload/test_fs_tier.py b/tests/v1/kv_offload/test_fs_tier.py index fcb5879b9b..e9e999449d 100644 --- a/tests/v1/kv_offload/test_fs_tier.py +++ b/tests/v1/kv_offload/test_fs_tier.py @@ -3,7 +3,7 @@ """ Unit tests for FileSystemTierManager. -These tests use real disk I/O to verify the Python filesystem tier implementation. +These tests use real disk I/O to verify the filesystem tier implementation. The tier manager writes KV cache blocks to disk and reads them back, verifying data integrity throughout the process. """ @@ -102,7 +102,7 @@ def fs_tier(tmp_path): tier = FileSystemTierManager( offloading_spec=_MOCK_OFFLOADING_SPEC, primary_kv_view=mock_view, - tier_type="fs_python", + tier_type="fs", root_dir=str(tmp_path), n_read_threads=4, n_write_threads=4, @@ -162,7 +162,7 @@ def test_invalid_path_raises_at_construction(): FileSystemTierManager( offloading_spec=_MOCK_OFFLOADING_SPEC, primary_kv_view=mock_view, - tier_type="fs_python", + tier_type="fs", root_dir="/dev/null/invalid_path", ) diff --git a/vllm/v1/kv_offload/tiering/factory.py b/vllm/v1/kv_offload/tiering/factory.py index bc5f1f6ad6..cbde45dfcf 100644 --- a/vllm/v1/kv_offload/tiering/factory.py +++ b/vllm/v1/kv_offload/tiering/factory.py @@ -59,7 +59,7 @@ SecondaryTierFactory.register_tier( ) SecondaryTierFactory.register_tier( - "fs_python", + "fs", "vllm.v1.kv_offload.tiering.fs.manager", "FileSystemTierManager", ) diff --git a/vllm/v1/kv_offload/tiering/fs/thread_pool.py b/vllm/v1/kv_offload/tiering/fs/thread_pool.py index 80704babd7..49bfeee44c 100644 --- a/vllm/v1/kv_offload/tiering/fs/thread_pool.py +++ b/vllm/v1/kv_offload/tiering/fs/thread_pool.py @@ -148,7 +148,7 @@ class DualQueueThreadPool: job_finished, success = state.task_done(True) except Exception as exc: logger.error( - "FileSystemTierManagerPython: job %s block I/O failed: %s", + "Job %s block I/O failed: %s", state.job_id, exc, )