[Frontend] Advertise --enable-x/--disable-x for boolean CLI flags (#61479)
Signed-off-by: mgoin <mgoin64@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
48f17b77bb
commit
1c4c319792
@@ -83,6 +83,51 @@ def test_with_bool_flag(parser):
|
||||
assert args.enable_feature is True
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def bool_parser():
|
||||
parser = FlexibleArgumentParser()
|
||||
serve = parser.add_subparsers().add_parser("serve")
|
||||
group = serve.add_argument_group("group")
|
||||
group.add_argument(
|
||||
"--enable-feature", "-ef", action=BooleanOptionalAction, default=None
|
||||
)
|
||||
group.add_argument("--disable-logs", action=BooleanOptionalAction, default=False)
|
||||
group.add_argument("--plain", action=BooleanOptionalAction, default=None)
|
||||
return parser, serve
|
||||
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
("args", "expected"),
|
||||
[
|
||||
([], (None, False, None)),
|
||||
(["--enable-feature", "--disable-logs"], (True, True, None)),
|
||||
(["-ef", "--enable-logs"], (True, False, None)),
|
||||
(["--disable-feature"], (False, False, None)),
|
||||
(["--disable_feature"], (False, False, None)),
|
||||
# Hidden backwards-compatible spellings
|
||||
(["--no-enable-feature", "--no-disable-logs"], (False, False, None)),
|
||||
(["--plain"], (None, False, True)),
|
||||
(["--no-plain"], (None, False, False)),
|
||||
],
|
||||
)
|
||||
def test_enable_disable_flags(bool_parser, args, expected):
|
||||
"""`--enable-x`/`--disable-x` are inverses, and `--no-*` still works."""
|
||||
parser, _ = bool_parser
|
||||
ns = parser.parse_args(["serve", *args])
|
||||
assert (ns.enable_feature, ns.disable_logs, ns.plain) == expected
|
||||
|
||||
|
||||
def test_enable_disable_flags_help(bool_parser):
|
||||
"""Help advertises `--enable-x`/`--disable-x` but not `--no-enable-x`."""
|
||||
_, serve = bool_parser
|
||||
usage = serve.format_usage()
|
||||
assert "[--enable-feature | -ef | --disable-feature]" in usage
|
||||
assert "[--disable-logs | --enable-logs]" in usage
|
||||
assert "[--plain | --no-plain]" in usage
|
||||
assert "--no-enable-feature" not in usage
|
||||
assert "--no-disable-logs" not in usage
|
||||
|
||||
|
||||
def test_invalid_choice(parser):
|
||||
with pytest.raises(SystemExit):
|
||||
parser.parse_args(["--image_input_type", "invalid_choice"])
|
||||
|
||||
Reference in New Issue
Block a user