[rl] Stateful Trainer Send: NCCL + Sparse NCCL [3/N] (#50902)
Signed-off-by: haoaaron <ahao@anyscale.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
43d691ec6b
commit
21ea5b4fa1
@@ -77,6 +77,7 @@ class WeightSource(ABC):
|
||||
|
||||
@abstractmethod
|
||||
def metadata(self) -> list[ParamMeta]:
|
||||
"""Declare what iteration will yield, without transferring anything."""
|
||||
raise NotImplementedError
|
||||
|
||||
@abstractmethod
|
||||
@@ -402,8 +403,7 @@ class TrainerWeightTransferEngine(ABC, Generic[TTrainerInitInfo]):
|
||||
Symmetric to `WeightTransferEngine` but lives in the training process.
|
||||
Constructed via the `trainer_init` factory classmethod; carries any
|
||||
backend-specific state (NCCL communicators, IPC device info, transfer
|
||||
plans) on `self`. The `WeightSource` is required at `trainer_init`,
|
||||
then replayed each round by the no-argument `send_weights()`.
|
||||
plans) on `self`.
|
||||
|
||||
Unlike the worker engine, the trainer side does not take a
|
||||
`WeightTransferConfig`: the backend is selected from the init info's
|
||||
@@ -431,7 +431,7 @@ class TrainerWeightTransferEngine(ABC, Generic[TTrainerInitInfo]):
|
||||
self,
|
||||
*,
|
||||
client: "VLLMWeightSyncClient",
|
||||
source: "WeightSource",
|
||||
source: "WeightSource | None" = None,
|
||||
is_sender: bool = True,
|
||||
) -> None:
|
||||
self.is_sender = is_sender
|
||||
@@ -447,24 +447,24 @@ class TrainerWeightTransferEngine(ABC, Generic[TTrainerInitInfo]):
|
||||
init_info: TTrainerInitInfo,
|
||||
*,
|
||||
client: "VLLMWeightSyncClient",
|
||||
source: "WeightSource",
|
||||
source: "WeightSource | None" = None,
|
||||
) -> Self:
|
||||
"""Rendezvous with the inference side and return a ready instance.
|
||||
|
||||
Called on every trainer rank. The sender drives the full handshake via
|
||||
`client` (build the worker-side init info, call
|
||||
`client.init_weight_transfer_engine`, open the trainer-side endpoint);
|
||||
non-sender ranks skip the rendezvous and the RPC. `source` is stored on
|
||||
`self.source`; after return, `send_weights()` is callable.
|
||||
non-sender ranks skip the rendezvous and the RPC.
|
||||
"""
|
||||
raise NotImplementedError
|
||||
|
||||
@abstractmethod
|
||||
def send_weights(self) -> None:
|
||||
"""Push `self.source`'s weights to inference workers and drive the full
|
||||
update round trip: `start_weight_update`, `update_weights` (run
|
||||
concurrently with the trainer-side broadcast when the backend requires
|
||||
it), then `finish_weight_update`. Called on every trainer rank."""
|
||||
"""Push weights to inference workers and drive the full update round
|
||||
trip: `start_weight_update`, `update_weights` (run concurrently with the
|
||||
trainer-side broadcast when the backend requires it), then
|
||||
`finish_weight_update`. Called on every trainer rank.
|
||||
"""
|
||||
raise NotImplementedError
|
||||
|
||||
def shutdown(self) -> None:
|
||||
|
||||
Reference in New Issue
Block a user