From 2622ee21aa4a9428aa0fc9a854c8aaacb5174643 Mon Sep 17 00:00:00 2001 From: rasmith Date: Wed, 14 Oct 2026 14:48:37 -0500 Subject: [PATCH] [ROCm][BugFix] Don't use AITER rms_norm as an IR OP on gfx90a when AITER always on. (#59290) Signed-off-by: Randall Smith Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> --- vllm/platforms/rocm.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/vllm/platforms/rocm.py b/vllm/platforms/rocm.py index 0792597bd2..ec3d26c92c 100644 --- a/vllm/platforms/rocm.py +++ b/vllm/platforms/rocm.py @@ -1354,12 +1354,14 @@ class RocmPlatform(Platform): default = ["native"] if using_inductor else ["vllm_c", "native"] # Aiter rms norm perform best when CUDA Graph capture is enabled. - # TODO(luka/TJ) remove env vars completely + # TODO(Rohan138/dllehr-amd/rasmith) Change this to be an inclusive + # check instead of exclusive check in the future. if ( cc.cudagraph_mode != CUDAGraphMode.NONE and envs.VLLM_ROCM_USE_AITER and envs.VLLM_ROCM_USE_AITER_RMSNORM and not on_rdna4() + and not on_gfx90a() # AITER not built for gfx90a, rmsnorm -> SEGV. ): rms_norm = ["aiter"] + default else: