From 2647163674720242cee78dae3f7c7b98539ed029 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Tue, 3 Feb 2026 20:37:51 -0800 Subject: [PATCH] Save startup benchmark results as a list of values (#33629) Signed-off-by: Huy Do --- vllm/benchmarks/lib/utils.py | 6 ++++++ vllm/benchmarks/startup.py | 8 ++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/vllm/benchmarks/lib/utils.py b/vllm/benchmarks/lib/utils.py index 6d8bfd021f..d3b6be8690 100644 --- a/vllm/benchmarks/lib/utils.py +++ b/vllm/benchmarks/lib/utils.py @@ -47,6 +47,12 @@ def convert_to_pytorch_benchmark_format( return records for name, benchmark_values in metrics.items(): + if not isinstance(benchmark_values, list): + raise TypeError( + f"benchmark_values for metric '{name}' must be a list, " + f"but got {type(benchmark_values).__name__}" + ) + record = { "benchmark": { "name": "vLLM benchmark", diff --git a/vllm/benchmarks/startup.py b/vllm/benchmarks/startup.py index dabda54773..005625f61b 100644 --- a/vllm/benchmarks/startup.py +++ b/vllm/benchmarks/startup.py @@ -101,7 +101,7 @@ def save_to_pytorch_benchmark_format( cold_startup_records = convert_to_pytorch_benchmark_format( args=args, metrics={ - "avg_cold_startup_time": results["avg_cold_startup_time"], + "avg_cold_startup_time": [results["avg_cold_startup_time"]], }, extra_info={ "cold_startup_times": results["cold_startup_times"], @@ -114,7 +114,7 @@ def save_to_pytorch_benchmark_format( cold_compilation_records = convert_to_pytorch_benchmark_format( args=args, metrics={ - "avg_cold_compilation_time": results["avg_cold_compilation_time"], + "avg_cold_compilation_time": [results["avg_cold_compilation_time"]], }, extra_info={ "cold_compilation_times": results["cold_compilation_times"], @@ -129,7 +129,7 @@ def save_to_pytorch_benchmark_format( warm_startup_records = convert_to_pytorch_benchmark_format( args=args, metrics={ - "avg_warm_startup_time": results["avg_warm_startup_time"], + "avg_warm_startup_time": [results["avg_warm_startup_time"]], }, extra_info={ "warm_startup_times": results["warm_startup_times"], @@ -142,7 +142,7 @@ def save_to_pytorch_benchmark_format( warm_compilation_records = convert_to_pytorch_benchmark_format( args=args, metrics={ - "avg_warm_compilation_time": results["avg_warm_compilation_time"], + "avg_warm_compilation_time": [results["avg_warm_compilation_time"]], }, extra_info={ "warm_compilation_times": results["warm_compilation_times"],