From 2adf4b9e2a915bd30876ab0c5dba2243f54fe5b7 Mon Sep 17 00:00:00 2001 From: Reid <61492567+reidliu41@users.noreply.github.com> Date: Fri, 21 Aug 2026 10:47:07 +0800 Subject: [PATCH] [Rust Frontend] Fix Kimi K3 reasoning_effort="none" handling (#53043) Co-authored-by: Bugen Zhao Signed-off-by: reidliu41 --- .../src/chat/src/renderer/kimi_k3/encoding.rs | 25 +++++++++---- rust/src/chat/src/renderer/kimi_k3/tests.rs | 36 ++++++++++++++++--- 2 files changed, 51 insertions(+), 10 deletions(-) diff --git a/rust/src/chat/src/renderer/kimi_k3/encoding.rs b/rust/src/chat/src/renderer/kimi_k3/encoding.rs index 3ff9242ff4..392b6b642d 100644 --- a/rust/src/chat/src/renderer/kimi_k3/encoding.rs +++ b/rust/src/chat/src/renderer/kimi_k3/encoding.rs @@ -236,11 +236,15 @@ fn thinking_enabled(request: &ChatRequest) -> Result { if let Some(enable_thinking) = request.parse_template_bool("enable_thinking")? { return Ok(enable_thinking); } + if let Some(reasoning_effort) = request.chat_options.reasoning_effort { + return Ok(reasoning_effort != crate::request::ReasoningEffort::None); + } Ok(request .chat_options - .reasoning_effort - .map(|effort| effort != crate::request::ReasoningEffort::None) - .unwrap_or(true)) + .template_kwargs + .get("reasoning_effort") + .and_then(Value::as_str) + != Some("none")) } fn thinking_effort(request: &ChatRequest) -> Result { @@ -251,13 +255,22 @@ fn thinking_effort(request: &ChatRequest) -> Result { )) })? } else if let Some(effort) = request.chat_options.reasoning_effort { - effort.as_str() + if effort == crate::request::ReasoningEffort::None { + DEFAULT_THINKING_EFFORT + } else { + effort.as_str() + } } else if let Some(value) = request.chat_options.template_kwargs.get("reasoning_effort") { - value.as_str().ok_or_else(|| { + let effort = value.as_str().ok_or_else(|| { Error::ChatTemplate(format!( "template kwarg `reasoning_effort` must be a string, got {value}" )) - })? + })?; + if effort == "none" { + DEFAULT_THINKING_EFFORT + } else { + effort + } } else { DEFAULT_THINKING_EFFORT }; diff --git a/rust/src/chat/src/renderer/kimi_k3/tests.rs b/rust/src/chat/src/renderer/kimi_k3/tests.rs index 94a3ad4cfe..1d9f984dbb 100644 --- a/rust/src/chat/src/renderer/kimi_k3/tests.rs +++ b/rust/src/chat/src/renderer/kimi_k3/tests.rs @@ -330,10 +330,10 @@ fn native_k3_kwargs_take_precedence() { #[test] fn standard_none_disables_thinking() { let mut request = crate::request::ChatRequest::for_test(); - request.chat_options.template_kwargs.extend([ - ("enable_thinking".to_string(), json!(false)), - ("reasoning_effort".to_string(), json!("none")), - ]); + request + .chat_options + .template_kwargs + .insert("reasoning_effort".to_string(), json!("none")); let rendered = render_request(&request); @@ -341,6 +341,34 @@ fn standard_none_disables_thinking() { assert!(rendered.ends_with("<|open|>response<|sep|>")); } +#[test] +fn native_thinking_true_overrides_standard_none() { + let mut request = crate::request::ChatRequest::for_test(); + request.chat_options.template_kwargs.extend([ + ("thinking".to_string(), json!(true)), + ("reasoning_effort".to_string(), json!("none")), + ]); + + let rendered = render_request(&request); + + assert!(rendered.contains("thinking_effort=max")); + assert!(rendered.ends_with("<|open|>think<|sep|>")); +} + +#[test] +fn enable_thinking_true_overrides_standard_none() { + let mut request = crate::request::ChatRequest::for_test(); + request.chat_options.template_kwargs.extend([ + ("enable_thinking".to_string(), json!(true)), + ("reasoning_effort".to_string(), json!("none")), + ]); + + let rendered = render_request(&request); + + assert!(rendered.contains("thinking_effort=max")); + assert!(rendered.ends_with("<|open|>think<|sep|>")); +} + #[test] fn typed_none_disables_thinking() { let mut request = crate::request::ChatRequest::for_test();