[DSV4] Support max reasoning effort (#40982)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
This commit is contained in:
Bugen Zhao
2026-04-29 11:03:47 +00:00
committed by GitHub
parent 37e288214b
commit 33f36d4260
6 changed files with 126 additions and 6 deletions
@@ -1002,6 +1002,31 @@ def test_chat_completion_request_n_parameter_default():
assert sampling_params.n == 1, f"Expected n=1 (default), got n={sampling_params.n}"
def test_chat_completion_request_accepts_model_specific_reasoning_effort():
request = ChatCompletionRequest(
model="test-model",
messages=[{"role": "user", "content": "Hello"}],
reasoning_effort="max",
)
chat_params = request.build_chat_params(
default_template=None,
default_template_content_format="auto",
)
assert request.reasoning_effort == "max"
assert chat_params.chat_template_kwargs["reasoning_effort"] == "max"
def test_chat_completion_request_rejects_unknown_reasoning_effort():
with pytest.raises(ValueError, match="Input should be"):
ChatCompletionRequest(
model="test-model",
messages=[{"role": "user", "content": "Hello"}],
reasoning_effort="extra_high",
)
def test_chat_completion_request_n_parameter_various_values():
"""Test n parameter with various values."""
for n_value in [1, 2, 5, 10]:
@@ -843,6 +843,13 @@ class TestGetSystemMessage:
f"{channel} missing when with_custom_tools={with_tools}"
)
def test_unsupported_reasoning_effort_raises_clear_error(self) -> None:
with pytest.raises(
ValueError,
match="reasoning_effort='max' is not supported by Harmony",
):
get_system_message(reasoning_effort="max")
class TestResponseInputToHarmonyReasoningItem:
"""Tests for response_input_to_harmony handling of reasoning input items.
+66 -1
View File
@@ -182,7 +182,7 @@ def test_deepseek_v4_renders_parsed_history_tool_arguments():
assert 'parameter name="arguments"' not in prompt
@pytest.mark.parametrize("reasoning_effort", ["none", "low", "medium", "high"])
@pytest.mark.parametrize("reasoning_effort", ["minimal", "low", "medium", "high"])
def test_deepseek_v4_accepts_openai_reasoning_effort_values(reasoning_effort):
prompt = _tokenizer().apply_chat_template(
[{"role": "user", "content": "Hello"}],
@@ -195,6 +195,58 @@ def test_deepseek_v4_accepts_openai_reasoning_effort_values(reasoning_effort):
assert "Reasoning Effort: Absolute maximum" not in prompt
def test_deepseek_v4_none_reasoning_effort_disables_thinking():
prompt = _tokenizer().apply_chat_template(
[{"role": "user", "content": "Hello"}],
tokenize=False,
enable_thinking=True,
reasoning_effort="none",
)
assert prompt == ("<|begin▁of▁sentence|><|User|>Hello<|Assistant|></think>")
@pytest.mark.parametrize(
("reasoning_effort", "expected_mode", "expected_effort"),
[
("none", "chat", None),
("minimal", "thinking", "high"),
("low", "thinking", "high"),
("medium", "thinking", "high"),
("high", "thinking", "high"),
("xhigh", "thinking", "max"),
("max", "thinking", "max"),
("unexpected", "thinking", "high"),
],
)
def test_deepseek_v4_maps_compatible_thinking_reasoning_effort_values(
monkeypatch: pytest.MonkeyPatch,
reasoning_effort,
expected_mode,
expected_effort,
):
captured_kwargs = []
def fake_encode_messages(messages, **kwargs):
captured_kwargs.append(kwargs)
return "prompt"
monkeypatch.setattr(
"vllm.tokenizers.deepseek_v4.encode_messages",
fake_encode_messages,
)
_tokenizer().apply_chat_template(
[{"role": "user", "content": "Hello"}],
tokenize=False,
enable_thinking=True,
reasoning_effort=reasoning_effort,
)
assert captured_kwargs[-1]["thinking_mode"] == expected_mode
assert captured_kwargs[-1]["reasoning_effort"] == expected_effort
def test_deepseek_v4_preserves_reference_max_reasoning_effort():
prompt = _tokenizer().apply_chat_template(
[{"role": "user", "content": "Hello"}],
@@ -208,6 +260,19 @@ def test_deepseek_v4_preserves_reference_max_reasoning_effort():
)
def test_deepseek_v4_maps_xhigh_to_reference_max_reasoning_effort():
prompt = _tokenizer().apply_chat_template(
[{"role": "user", "content": "Hello"}],
tokenize=False,
enable_thinking=True,
reasoning_effort="xhigh",
)
assert prompt.startswith(
"<|begin▁of▁sentence|>Reasoning Effort: Absolute maximum"
)
@pytest.mark.parametrize(
("case_id", "kwargs"),
[