[DSV4] Support max reasoning effort (#40982)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
This commit is contained in:
Bugen Zhao
2026-04-29 11:03:47 +00:00
committed by GitHub
parent 37e288214b
commit 33f36d4260
6 changed files with 126 additions and 6 deletions
@@ -1002,6 +1002,31 @@ def test_chat_completion_request_n_parameter_default():
assert sampling_params.n == 1, f"Expected n=1 (default), got n={sampling_params.n}"
def test_chat_completion_request_accepts_model_specific_reasoning_effort():
request = ChatCompletionRequest(
model="test-model",
messages=[{"role": "user", "content": "Hello"}],
reasoning_effort="max",
)
chat_params = request.build_chat_params(
default_template=None,
default_template_content_format="auto",
)
assert request.reasoning_effort == "max"
assert chat_params.chat_template_kwargs["reasoning_effort"] == "max"
def test_chat_completion_request_rejects_unknown_reasoning_effort():
with pytest.raises(ValueError, match="Input should be"):
ChatCompletionRequest(
model="test-model",
messages=[{"role": "user", "content": "Hello"}],
reasoning_effort="extra_high",
)
def test_chat_completion_request_n_parameter_various_values():
"""Test n parameter with various values."""
for n_value in [1, 2, 5, 10]:
@@ -843,6 +843,13 @@ class TestGetSystemMessage:
f"{channel} missing when with_custom_tools={with_tools}"
)
def test_unsupported_reasoning_effort_raises_clear_error(self) -> None:
with pytest.raises(
ValueError,
match="reasoning_effort='max' is not supported by Harmony",
):
get_system_message(reasoning_effort="max")
class TestResponseInputToHarmonyReasoningItem:
"""Tests for response_input_to_harmony handling of reasoning input items.