[ROCm] Give EngineCore cleanup grace after request abort (#52281)

Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This commit is contained in:
Andreas Karatzas
2026-08-19 11:39:59 -05:00
committed by GitHub
co-authored by OpenAI Codex mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
parent e9e1630e93
commit 3a386cfaf5
5 changed files with 221 additions and 3 deletions
+17 -1
View File
@@ -1276,6 +1276,7 @@ class EngineCoreProc(EngineCore):
engine_core: EngineCoreProc | None = None
signal_callback: SignalCallback | None = None
clean_shutdown = False
try:
vllm_config: VllmConfig = kwargs["vllm_config"]
parallel_config: ParallelConfig = vllm_config.parallel_config
@@ -1338,8 +1339,15 @@ class EngineCoreProc(EngineCore):
engine_core.run_busy_loop()
except SystemExit:
except SystemExit as e:
logger.info_once("[shutdown] EngineCore: exiting busy loop")
clean_shutdown = (
e.code in (None, 0)
and engine_core is not None
and engine_core.shutdown_state == EngineShutdownState.SHUTTING_DOWN
and not engine_core.has_work()
and engine_core.vllm_config.shutdown_timeout == 0
)
raise
except Exception as e:
if engine_core is None:
@@ -1355,6 +1363,14 @@ class EngineCoreProc(EngineCore):
signal_callback.stop()
if engine_core is not None:
engine_core.shutdown()
if clean_shutdown:
from vllm.platforms import current_platform
if current_platform.is_rocm():
# Cleanup above already unfreezes and collects the heap.
# Freeze the surviving graph to skip another slow cyclic-GC
# scan during finalization; process exit reclaims it.
gc.freeze()
def _init_data_parallel(self, vllm_config: VllmConfig):
pass