[Bugfix] Fix Opencv video backend frames count missing for WebM video inputs (#61759)

Signed-off-by: Isotr0py <Isotr0py@outlook.com>
This commit is contained in:
Isotr0py
2026-10-18 10:37:39 +00:00
committed by GitHub
parent 2365177ddd
commit 3f1b04e045
3 changed files with 122 additions and 9 deletions
+29 -3
View File
@@ -38,7 +38,9 @@ def decode_opencv(
int(cap.get(cv2.CAP_PROP_FRAME_WIDTH)),
int(cap.get(cv2.CAP_PROP_FRAME_HEIGHT)),
)
source = loader_cls._prepare_source(OpenCVVideoBackendMixin.get_video_metadata(cap))
source = loader_cls._prepare_source(
OpenCVVideoBackendMixin.get_video_metadata(data)
)
frame_idx = loader_cls.compute_frames_index_to_sample(
source=source, target=target, **sampling_kwargs
)
@@ -74,10 +76,34 @@ class OpenCVVideoBackendMixin:
raise ValueError("Could not open video stream")
return cap
@classmethod
def demux_count_frames(cls, data: bytes) -> int:
"""Count frames with OpenCV's demuxer-only mode."""
# NOTE: buf must stay referenced until after release().
# OpenCV's Python stream binding does not safely own the stream object
buf = BytesIO(data)
demux_cap = cv2.VideoCapture(
buf, cls.get_cv2_video_api(), [cv2.CAP_PROP_FORMAT, -1]
)
count = 0
while demux_cap.grab():
count += 1
demux_cap.release()
if count == 0:
raise ValueError("Could not determine the number of video frames")
return count
@staticmethod
def get_video_metadata(cap: "cv2.VideoCapture") -> VideoSourceMetadata:
def get_video_metadata(data: bytes) -> VideoSourceMetadata:
cap = OpenCVVideoBackendMixin.open_video_capture(data)
total_frames_num = int(cap.get(cv2.CAP_PROP_FRAME_COUNT))
original_fps = cap.get(cv2.CAP_PROP_FPS)
if total_frames_num <= 0:
# Streamed WebM/MKV and raw H.264 miss frame count in headers;
# We need to use demux frames count for retrieval
total_frames_num = OpenCVVideoBackendMixin.demux_count_frames(data)
duration = total_frames_num / original_fps if original_fps > 0 else 0
return VideoSourceMetadata(total_frames_num, original_fps, duration)
# CAP_PROP_FRAME_COUNT counts every physical sample in the container,
# overstating the presentable frames when an mp4 edit list hides the
# decode lead-in (e.g. a lossless `ffmpeg -ss ... -c copy` trim).
@@ -87,7 +113,7 @@ class OpenCVVideoBackendMixin:
# may land mid-stream on corrupt files, so only trust it when the
# stream really ends there. A one-frame tolerance keeps mere header
# miscounts from being "corrected".
if total_frames_num > 0 and cap.set(cv2.CAP_PROP_POS_AVI_RATIO, 1.0):
if cap.set(cv2.CAP_PROP_POS_AVI_RATIO, 1.0):
visible_frames = int(cap.get(cv2.CAP_PROP_POS_FRAMES))
at_stream_end = not cap.grab()
cap.set(cv2.CAP_PROP_POS_FRAMES, 0)