[Bugfix][KV Offload] Submit CPU stores on no-forward steps (#56621)

Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
This commit is contained in:
Lucas Wilkinson
2026-09-13 05:56:14 +00:00
committed by GitHub
parent 0cf266a469
commit 410f6da5c4
2 changed files with 110 additions and 4 deletions
+10 -1
View File
@@ -67,6 +67,7 @@ class SimpleCPUOffloadWorker:
# Metadata for the current step
self._connector_metadata: SimpleCPUOffloadMetadata | None = None
self._store_submitted = False
# Compute-done event recorded before each store; reused across steps
# (get_finished runs once per step, copy queue is FIFO).
@@ -244,12 +245,15 @@ class SimpleCPUOffloadWorker:
def bind_connector_metadata(self, metadata: SimpleCPUOffloadMetadata) -> None:
self._connector_metadata = metadata
self._store_submitted = False
if metadata.load_event >= 0:
self._pending_load_event_indices.add(metadata.load_event)
if metadata.store_event >= 0:
self._pending_store_event_indices.add(metadata.store_event)
def clear_connector_metadata(self) -> None:
# No-forward steps skip the normal wait_for_save hook.
self.wait_for_save()
self._connector_metadata = None
def start_load_kv(self) -> None:
@@ -278,7 +282,11 @@ class SimpleCPUOffloadWorker:
#45704 for the bug and #39306 for the srcAccessOrder rationale.
"""
metadata = self._connector_metadata
if metadata is not None and metadata.store_gpu_blocks:
if (
metadata is not None
and metadata.store_gpu_blocks
and not self._store_submitted
):
backend = self._backend
assert backend is not None
if self._store_compute_done is None:
@@ -292,6 +300,7 @@ class SimpleCPUOffloadWorker:
events_list=self._store_events,
wait_event=self._store_compute_done,
)
self._store_submitted = True
def get_finished(
self, finished_req_ids: set[str]