[Rust Frontend] Simplify data-parallel size ownership (#52575)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Co-authored-by: Nick Hill <nickhill123@gmail.com>
This commit is contained in:
Bugen Zhao
2026-08-18 09:06:05 +00:00
committed by GitHub
co-authored by Nick Hill
parent eab1cff5b0
commit 41f179b57a
19 changed files with 188 additions and 134 deletions
+1 -2
View File
@@ -474,9 +474,9 @@ impl SharedRuntimeArgs {
output_address,
engine_start_index,
engine_count,
data_parallel_size,
ready_timeout,
},
data_parallel_size,
coordinator_mode: match coordinator_address {
Some(address) => CoordinatorMode::External { address },
None => CoordinatorMode::None,
@@ -533,7 +533,6 @@ impl SharedRuntimeArgs {
local_input_address,
local_output_address,
},
data_parallel_size: engine_count,
coordinator_mode: CoordinatorMode::MaybeInProc,
model: self.model,
served_model_name: self.served_model_name,
+2 -4
View File
@@ -864,7 +864,7 @@ fn frontend_args_json_applies_defaults() {
assert_eq!(args.runtime.renderer, RendererSelection::Auto);
assert_eq!(args.runtime.max_logprobs, None);
assert_eq!(args.runtime.shutdown_timeout, 0);
assert_eq!(args.into_config().data_parallel_size, 4);
assert_eq!(args.into_config().transport_mode.data_parallel_size(), 4);
}
#[test]
@@ -1521,7 +1521,6 @@ fn serve_frontend_config_uses_dp_address_as_advertised_host() {
"<ipc output>",
),
},
data_parallel_size: 4,
coordinator_mode: MaybeInProc,
model: "Qwen/Qwen3-0.6B",
served_model_name: [],
@@ -1607,7 +1606,6 @@ fn serve_frontend_config_keeps_tcp_transport_for_non_local_only_topology() {
local_input_address: None,
local_output_address: None,
},
data_parallel_size: 4,
coordinator_mode: MaybeInProc,
model: "Qwen/Qwen3-0.6B",
served_model_name: [],
@@ -1710,9 +1708,9 @@ fn frontend_config_uses_external_coordinator_when_coordinator_address_is_present
output_address: "ipc:///tmp/output.sock",
engine_start_index: 3,
engine_count: 1,
data_parallel_size: 4,
ready_timeout: 600s,
},
data_parallel_size: 4,
coordinator_mode: External {
address: "tcp://127.0.0.1:7000",
},