[Bugfix][KV-transfer] MoRIIO: per-layer READ-completion barrier in wait_for_layer_load (#48534)
Signed-off-by: Edwin Lim <edwin.lim@mangoboost.io> Signed-off-by: Redwan Khan <redwan.khan@mangoboost.io> Signed-off-by: harishk-mangoboost <harish.kambhampaty@mangoboost.io> Signed-off-by: limeward <32970461+edwinlim0919@users.noreply.github.com> Signed-off-by: QinPR <1905873179@qq.com> Co-authored-by: Jaeyoun Kim <jaeyoun.kim@mangoboost.io> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Redwan Khan <redwan.khan@mangoboost.io> Co-authored-by: harishk-mangoboost <harish.kambhampaty@mangoboost.io> Co-authored-by: rkhan055 <redwankhan055@gmail.com> Co-authored-by: Peiran Qin <66068739+QinPR@users.noreply.github.com> Co-authored-by: QinPR <1905873179@qq.com>
This commit is contained in:
co-authored by
Jaeyoun Kim
Claude Opus 4.8
Redwan Khan
harishk-mangoboost
rkhan055
Peiran Qin
QinPR
parent
d4ecb75ba2
commit
47228db84c
@@ -10,6 +10,7 @@ from vllm.distributed.kv_transfer.kv_connector.v1.moriio.moriio_common import (
|
||||
MoRIIOTransferAck,
|
||||
)
|
||||
from vllm.distributed.kv_transfer.kv_connector.v1.moriio.moriio_connector import (
|
||||
MoRIIOConnector,
|
||||
MoRIIOConnectorWorker,
|
||||
get_moriio_expected_ack_count,
|
||||
get_moriio_remote_tp_rank,
|
||||
@@ -292,7 +293,7 @@ def test_read_completion_sends_structured_release_with_consumer_tp_size():
|
||||
worker = MoRIIOConnectorWorker.__new__(MoRIIOConnectorWorker)
|
||||
worker.world_size = 8
|
||||
worker.moriio_wrapper = FakeWrapper()
|
||||
worker._recving_transfers = {"req": [DoneStatus()]}
|
||||
worker._recving_transfers = {"req": {"layer0": DoneStatus()}}
|
||||
worker._recving_transfers_callback_addr = {
|
||||
"req": ("127.0.0.1", "7000", "tx-release")
|
||||
}
|
||||
@@ -311,3 +312,15 @@ def test_read_completion_sends_structured_release_with_consumer_tp_size():
|
||||
]
|
||||
assert worker._recving_transfers == {}
|
||||
assert worker._recving_transfers_callback_addr == {}
|
||||
|
||||
|
||||
def test_requested_cudagraph_mode_is_never_overridden():
|
||||
# The configured cudagraph mode is always honored: the barrier fires when
|
||||
# the operator sets cudagraph_mode=PIECEWISE, and READ mode with full
|
||||
# graphs only warns instead of silently forcing PIECEWISE.
|
||||
assert (
|
||||
MoRIIOConnector.requires_piecewise_for_cudagraph({"read_mode": True}) is False
|
||||
)
|
||||
assert (
|
||||
MoRIIOConnector.requires_piecewise_for_cudagraph({"read_mode": False}) is False
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user