[Bugfix][NIXL] Avoid receive reports for notification-only requests (#57570)
Signed-off-by: NickLucche <nicolo.lucchesi@mistral.ai> Co-authored-by: OpenAI Codex <codex@openai.com>
This commit is contained in:
co-authored by
OpenAI Codex
parent
63d9ad0a3a
commit
49e0427ca5
@@ -64,8 +64,14 @@ class NixlPullConnectorWorker(NixlBaseConnectorWorker):
|
||||
len(meta.local_physical_block_ids),
|
||||
len(meta.remote.block_ids),
|
||||
)
|
||||
# always store metadata for failure recovery
|
||||
self._recving_metadata[req_id] = meta
|
||||
# Full local hits and aborted cleanup only notify P; no recv is awaited.
|
||||
# On a full local hit:
|
||||
# - Notification failure must not fail the request: its KV is local.
|
||||
# - Receive completion must not be reported: num_external_tokens == 0,
|
||||
# so the scheduler never entered WAITING_FOR_REMOTE_KVS to begin with.
|
||||
# Aborted cleanup requests have already been removed from the scheduler.
|
||||
if meta.awaiting_kvs or any(meta.local_block_ids):
|
||||
self._recving_metadata[req_id] = meta
|
||||
if remote_engine_id not in self._remote_agents:
|
||||
# Initiate handshake with remote engine to exchange metadata.
|
||||
with self._handshake_lock:
|
||||
|
||||
Reference in New Issue
Block a user