[Bugfix][Frontend] Preserve logprobs when top_logprobs is null (#47838)

Signed-off-by: Ting Sun <suntcrick@gmail.com>
Signed-off-by: Flora Feng <4florafeng@gmail.com>
Co-authored-by: Flora Feng <4florafeng@gmail.com>
This commit is contained in:
Ting SUN
2026-10-05 22:43:31 +00:00
committed by GitHub
co-authored by Flora Feng
parent 89a00995c9
commit 4a705c7b54
7 changed files with 46 additions and 12 deletions
@@ -16,6 +16,7 @@ from openai import BadRequestError
from tests.utils import RemoteOpenAIServer
from vllm.entrypoints.openai.chat_completion.protocol import (
BatchChatCompletionRequest,
ChatCompletionRequest,
)
from vllm.exceptions import VLLMValidationError
@@ -1012,6 +1013,22 @@ def test_chat_completion_request_n_parameter_default():
assert sampling_params.n == 1, f"Expected n=1 (default), got n={sampling_params.n}"
@pytest.mark.parametrize(
("request_cls", "messages"),
[
(ChatCompletionRequest, [{"role": "user", "content": "Hello"}]),
(BatchChatCompletionRequest, [[{"role": "user", "content": "Hello"}]]),
],
)
def test_null_top_logprobs_is_same_as_omitted(request_cls, messages):
"""`top_logprobs: null` must not switch off `logprobs: true`."""
request = request_cls.model_validate(
{"messages": messages, "logprobs": True, "top_logprobs": None}
)
assert request.top_logprobs == 0
def test_chat_completion_request_accepts_model_specific_reasoning_effort():
request = ChatCompletionRequest(
model="test-model",
@@ -84,6 +84,20 @@ class TestResponsesRequestSamplingParams:
assert sampling_params.stop == [] # Empty list
assert sampling_params.extra_args == {} # Empty dict
def test_null_top_logprobs_is_same_as_omitted(self):
"""`top_logprobs: null` must not drop the requested output logprobs."""
request = ResponsesRequest.model_validate(
{
"input": "test input",
"include": ["message.output_text.logprobs"],
"top_logprobs": None,
}
)
sampling_params = request.to_sampling_params(default_max_tokens=1000)
assert sampling_params.logprobs == 0
def test_seed_bounds_validation(self):
"""Test that seed values outside torch.long bounds are rejected."""
# Test seed below minimum