[Bugfix][Parser] Stream Gemma4 string tool arguments incrementally (#61494)

Signed-off-by: Ben Browning <56071+bbrowning@users.noreply.github.com>
Co-authored-by: Flora Feng <4florafeng@gmail.com>
This commit is contained in:
Ben Browning
2026-10-14 21:25:41 +00:00
committed by GitHub
co-authored by Flora Feng
parent 984c242ede
commit 4c5ea86f53
5 changed files with 369 additions and 22 deletions
+7 -6
View File
@@ -342,8 +342,10 @@ class ParserEngine(Parser):
their unterminated content instead of buffering long arguments until
the closing tag arrives.
Also returns whether the prefix ends inside that streamed trailing
string value.
Also returns whether the returned prefix stops inside that trailing
string, so streamed text may be appended to it. This holds even when
*json_str* closes the string: converters serialise an open raw value
as a closed JSON string.
"""
last_colon = -1
last_key: str | None = None
@@ -1053,11 +1055,8 @@ class ParserEngine(Parser):
if not self._stream_arg_deltas:
return None
structural = self._arg_structural_chars
if structural is not None and structural.isdisjoint(raw_delta):
return None
slot = self._tool_slots[idx]
structural = self._arg_structural_chars
if slot.extend_open_value is not None:
diff = slot.extend_open_value(raw_delta)
if diff is not None:
@@ -1066,6 +1065,8 @@ class ParserEngine(Parser):
slot.append_streamed(diff)
return diff
slot.extend_open_value = None
elif structural is not None and structural.isdisjoint(raw_delta):
return None
try:
current_json = converter(slot.args, True)