From 4db300e95fd29f5b1a4a7c34f4fbe91b7e9abb24 Mon Sep 17 00:00:00 2001 From: Andreas Karatzas Date: Sat, 16 May 2026 04:35:05 -0500 Subject: [PATCH] [ROCm][CI] Removed problematic command override mechanism (#42807) Signed-off-by: Andreas Karatzas --- .../scripts/hardware_ci/run-amd-test.sh | 100 +----------------- 1 file changed, 1 insertion(+), 99 deletions(-) diff --git a/.buildkite/scripts/hardware_ci/run-amd-test.sh b/.buildkite/scripts/hardware_ci/run-amd-test.sh index 7e8ddb12ec..9008d7ba31 100755 --- a/.buildkite/scripts/hardware_ci/run-amd-test.sh +++ b/.buildkite/scripts/hardware_ci/run-amd-test.sh @@ -114,8 +114,7 @@ handle_pytest_exit() { # unquoted since they have no spaces and work fine. # # Already-quoted expressions (containing literal single quotes) are passed -# through untouched to avoid double-quoting values injected by -# apply_rocm_test_overrides. +# through untouched to avoid double-quoting well-formed shell fragments. # # NOTE: This ONLY fixes -m/-k flags. It cannot recover arbitrary inner # double-quotes stripped by the calling shell (see header comment). @@ -247,102 +246,6 @@ re_quote_pytest_markers() { echo "${output% }" } -############################################################################### -# ROCm-specific pytest command rewrites -# -# These apply ignore flags and environment overrides for tests that are not -# yet supported or behave differently on ROCm hardware. Kept as a single -# function so new exclusions are easy to add in one place. -############################################################################### - -apply_rocm_test_overrides() { - local cmds="$1" - - # --- Model registry filter --- - if [[ $cmds == *"pytest -v -s models/test_registry.py"* ]]; then - cmds=${cmds//"pytest -v -s models/test_registry.py"/"pytest -v -s models/test_registry.py -k 'not BambaForCausalLM and not GritLM and not Mamba2ForCausalLM and not Zamba2ForCausalLM'"} - fi - - # --- LoRA: disable custom paged attention --- - if [[ $cmds == *"pytest -v -s lora"* ]]; then - cmds=${cmds//"pytest -v -s lora"/"pytest -v -s lora"} - fi - - # --- Kernel ignores --- - if [[ $cmds == *" kernels/core"* ]]; then - cmds="${cmds} \ - --ignore=kernels/core/test_fused_quant_layernorm.py \ - --ignore=kernels/core/test_permute_cols.py" - fi - - if [[ $cmds == *" kernels/attention"* ]]; then - cmds="${cmds} \ - --ignore=kernels/attention/test_attention_selector.py \ - --ignore=kernels/attention/test_encoder_decoder_attn.py \ - --ignore=kernels/attention/test_flash_attn.py \ - --ignore=kernels/attention/test_flashinfer.py \ - --ignore=kernels/attention/test_prefix_prefill.py \ - --ignore=kernels/attention/test_cascade_flash_attn.py \ - --ignore=kernels/attention/test_mha_attn.py \ - --ignore=kernels/attention/test_lightning_attn.py \ - --ignore=kernels/attention/test_attention.py" - fi - - if [[ $cmds == *" kernels/quantization"* ]]; then - cmds="${cmds} \ - --ignore=kernels/quantization/test_int8_quant.py \ - --ignore=kernels/quantization/test_machete_mm.py \ - --ignore=kernels/quantization/test_block_fp8.py \ - --ignore=kernels/quantization/test_block_int8.py \ - --ignore=kernels/quantization/test_marlin_gemm.py \ - --ignore=kernels/quantization/test_cutlass_scaled_mm.py \ - --ignore=kernels/quantization/test_int8_kernel.py" - fi - - if [[ $cmds == *" kernels/mamba"* ]]; then - cmds="${cmds} \ - --ignore=kernels/mamba/test_mamba_mixer2.py \ - --ignore=kernels/mamba/test_causal_conv1d.py \ - --ignore=kernels/mamba/test_mamba_ssm_ssd.py" - fi - - if [[ $cmds == *" kernels/moe"* ]]; then - cmds="${cmds} \ - --ignore=kernels/moe/test_moe.py \ - --ignore=kernels/moe/test_cutlass_moe.py" - fi - - # --- Entrypoint ignores --- - if [[ $cmds == *" entrypoints/openai "* ]]; then - cmds=${cmds//" entrypoints/openai "/" entrypoints/openai \ - --ignore=entrypoints/openai/chat_completion/test_audio.py \ - --ignore=entrypoints/openai/completion/test_shutdown.py \ - --ignore=entrypoints/openai/test_completion.py \ - --ignore=entrypoints/openai/models/test_models.py \ - --ignore=entrypoints/openai/test_return_tokens_as_ids.py \ - --ignore=entrypoints/openai/chat_completion/test_root_path.py \ - --ignore=entrypoints/openai/completion/test_prompt_validation.py "} - fi - - if [[ $cmds == *" entrypoints/serve"* ]]; then - cmds="${cmds} \ - --ignore=entrypoints/serve/lora/test_lora_adapters.py" - fi - - if [[ $cmds == *" entrypoints/llm "* ]]; then - cmds=${cmds//" entrypoints/llm "/" entrypoints/llm \ - --ignore=entrypoints/llm/test_chat.py \ - --ignore=entrypoints/llm/test_accuracy.py \ - --ignore=entrypoints/llm/test_init.py \ - --ignore=entrypoints/llm/test_prompt_validation.py "} - fi - - # Clean up escaped newlines from --ignore appends - cmds=$(echo "$cmds" | sed 's/ \\ / /g') - - echo "$cmds" -} - ############################################################################### # Main ############################################################################### @@ -409,7 +312,6 @@ else echo "Skipping re-quoting for VLLM_TEST_COMMANDS input" fi -commands=$(apply_rocm_test_overrides "$commands") echo "Final commands: $commands" MYPYTHONPATH=".."