From 500121136995ff0b261f4d2f68e4831896e32d63 Mon Sep 17 00:00:00 2001 From: TJian Date: Thu, 12 Feb 2026 02:50:44 +0800 Subject: [PATCH] [ROCm] [CI] fix test_unrecognized_env (#34350) Signed-off-by: tjtanaa --- tests/config/test_config_generation.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/config/test_config_generation.py b/tests/config/test_config_generation.py index 225ac0f222..c7edf2b971 100644 --- a/tests/config/test_config_generation.py +++ b/tests/config/test_config_generation.py @@ -80,12 +80,19 @@ def test_ray_runtime_env(monkeypatch: pytest.MonkeyPatch): ray.shutdown() -def test_unrecognized_env(): +def test_unrecognized_env(monkeypatch): import os + from vllm.envs import environment_variables + + # Remove any existing unrecognized VLLM env vars that might interfere + for env in list(os.environ): + if env.startswith("VLLM_") and env not in environment_variables: + monkeypatch.delenv(env, raising=False) + # Test that if fail_on_environ_validation is True, then an error # is raised when an unrecognized vLLM environment variable is set - os.environ["VLLM_UNRECOGNIZED_ENV_VAR"] = "some_value" + monkeypatch.setenv("VLLM_UNRECOGNIZED_ENV_VAR", "some_value") engine_args = EngineArgs( fail_on_environ_validation=True, ) @@ -97,7 +104,7 @@ def test_unrecognized_env(): engine_args.create_engine_config() # Test that when the unrecognized env var is removed, no error is raised - os.environ.pop("VLLM_UNRECOGNIZED_ENV_VAR", None) + monkeypatch.delenv("VLLM_UNRECOGNIZED_ENV_VAR") engine_args = EngineArgs( fail_on_environ_validation=True, )