[MyPy][3/N] Fix MyPy errors in test groups (part 3) (#55939)

Signed-off-by: Taimys <ffy2281693949@gmail.com>
Signed-off-by: Luyi Xiao <81631911+luyixiao95@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Luyi Xiao <81631911+luyixiao95@users.noreply.github.com>
Co-authored-by: Taimys <ffy2281693949@gmail.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Taimys
2026-09-30 11:06:07 +00:00
committed by GitHub
co-authored by Codex Luyi Xiao Taimys Harry Mellor Claude Opus 5.5
parent c4fa6f36a7
commit 5225f1bacb
118 changed files with 948 additions and 605 deletions
+8 -8
View File
@@ -116,7 +116,7 @@ class TestParameterSweep:
def test_from_records_list(self):
"""Test creating ParameterSweep from a list of records."""
records = [
records: list[dict[str, object]] = [
{"max_tokens": 100, "temperature": 0.7},
{"max_tokens": 200, "temperature": 0.9},
]
@@ -127,7 +127,7 @@ class TestParameterSweep:
def test_read_from_dict(self):
"""Test creating ParameterSweep from a dict format."""
data = {
data: dict[str, dict[str, object]] = {
"experiment1": {"max_tokens": 100, "temperature": 0.7},
"experiment2": {"max_tokens": 200, "temperature": 0.9},
}
@@ -149,7 +149,7 @@ class TestParameterSweep:
def test_read_json_list_format(self):
"""Test reading JSON file with list format."""
records = [
records: list[dict[str, object]] = [
{"max_tokens": 100, "temperature": 0.7},
{"max_tokens": 200, "temperature": 0.9},
]
@@ -168,7 +168,7 @@ class TestParameterSweep:
def test_read_json_dict_format(self):
"""Test reading JSON file with dict format."""
data = {
data: dict[str, dict[str, object]] = {
"experiment1": {"max_tokens": 100, "temperature": 0.7},
"experiment2": {"max_tokens": 200, "temperature": 0.9},
}
@@ -190,7 +190,7 @@ class TestParameterSweep:
def test_unique_benchmark_names_validation(self):
"""Test that duplicate _benchmark_name values raise an error."""
# Test with duplicate names in list format
records = [
records: list[dict[str, object]] = [
{"_benchmark_name": "exp1", "max_tokens": 100},
{"_benchmark_name": "exp1", "max_tokens": 200},
]
@@ -200,7 +200,7 @@ class TestParameterSweep:
def test_unique_benchmark_names_multiple_duplicates(self):
"""Test validation with multiple duplicate names."""
records = [
records: list[dict[str, object]] = [
{"_benchmark_name": "exp1", "max_tokens": 100},
{"_benchmark_name": "exp1", "max_tokens": 200},
{"_benchmark_name": "exp2", "max_tokens": 300},
@@ -212,7 +212,7 @@ class TestParameterSweep:
def test_no_benchmark_names_allowed(self):
"""Test that records without _benchmark_name are allowed."""
records = [
records: list[dict[str, object]] = [
{"max_tokens": 100, "temperature": 0.7},
{"max_tokens": 200, "temperature": 0.9},
]
@@ -221,7 +221,7 @@ class TestParameterSweep:
def test_mixed_benchmark_names_allowed(self):
"""Test that mixing records with and without _benchmark_name is allowed."""
records = [
records: list[dict[str, object]] = [
{"_benchmark_name": "exp1", "max_tokens": 100},
{"max_tokens": 200, "temperature": 0.9},
]
+10 -5
View File
@@ -13,6 +13,7 @@ import soundfile as sf
import vllm.benchmarks.datasets.datasets as datasets_module
import vllm.benchmarks.lib.endpoint_request_func as request_func_module
from vllm.benchmarks.lib.endpoint_request_func import RequestFuncInput
from vllm.tokenizers import TokenizerLike
pytestmark = pytest.mark.skip_global_cleanup
@@ -44,6 +45,10 @@ class _CohereNameOnlyTokenizer(_Tokenizer):
super().__init__("cohere/some-local-checkpoint")
def _as_tokenizer(tokenizer: _Tokenizer) -> TokenizerLike:
return cast(TokenizerLike, tokenizer)
def _write_wav(path: Path, duration_s: float = 0.1, sample_rate: int = 16_000) -> None:
num_samples = int(duration_s * sample_rate)
sf.write(path, np.zeros(num_samples, dtype=np.float32), sample_rate)
@@ -109,7 +114,7 @@ def test_asr_dataset_sample_handles_local_audio_paths(tmp_path: Path) -> None:
]
samples = dataset.sample(
tokenizer=_Tokenizer(),
tokenizer=_as_tokenizer(_Tokenizer()),
num_requests=1,
output_len=32,
asr_min_audio_len_sec=0.0,
@@ -146,7 +151,7 @@ def test_asr_dataset_sample_handles_embedded_audio_bytes(
]
samples = dataset.sample(
tokenizer=_Tokenizer(),
tokenizer=_as_tokenizer(_Tokenizer()),
num_requests=1,
output_len=32,
asr_min_audio_len_sec=0.0,
@@ -240,7 +245,7 @@ def _make_asr_dataset(tmp_path: Path) -> datasets_module.ASRDataset:
def test_asr_dataset_cohere_class_name_gets_decoder_prompt(tmp_path: Path) -> None:
dataset = _make_asr_dataset(tmp_path)
samples = dataset.sample(
tokenizer=CohereAsrTokenizer(),
tokenizer=_as_tokenizer(CohereAsrTokenizer()),
num_requests=1,
output_len=32,
asr_min_audio_len_sec=0.0,
@@ -255,7 +260,7 @@ def test_asr_dataset_cohere_name_or_path_fallback_gets_decoder_prompt(
) -> None:
dataset = _make_asr_dataset(tmp_path)
samples = dataset.sample(
tokenizer=_CohereNameOnlyTokenizer(),
tokenizer=_as_tokenizer(_CohereNameOnlyTokenizer()),
num_requests=1,
output_len=32,
asr_min_audio_len_sec=0.0,
@@ -268,7 +273,7 @@ def test_asr_dataset_cohere_name_or_path_fallback_gets_decoder_prompt(
def test_asr_dataset_unknown_tokenizer_gets_empty_prompt(tmp_path: Path) -> None:
dataset = _make_asr_dataset(tmp_path)
samples = dataset.sample(
tokenizer=_Tokenizer(name_or_path="some-other/asr-model"),
tokenizer=_as_tokenizer(_Tokenizer(name_or_path="some-other/asr-model")),
num_requests=1,
output_len=32,
asr_min_audio_len_sec=0.0,
+2 -2
View File
@@ -271,7 +271,7 @@ def test_bfcl_prompt_len_includes_tools(tmp_path: Path) -> None:
args.num_prompts = 1
with _patch_hf_api(fake_download):
samples = get_samples(args, fake)
samples = get_samples(args, fake) # type: ignore[arg-type]
assert len(samples) == 1
assert captured["tools"] is not None, (
@@ -311,7 +311,7 @@ def test_bfcl_prompt_len_falls_back_when_tokenizer_rejects_tools(
args.num_prompts = 1
with _patch_hf_api(fake_download):
samples = get_samples(args, _LegacyTokenizer())
samples = get_samples(args, _LegacyTokenizer()) # type: ignore[arg-type]
assert len(samples) == 1
assert samples[0].prompt_len > 0
@@ -58,7 +58,7 @@ def test_chat_template_kwargs_forwarded(tmp_path: Path) -> None:
_write_one(jsonl)
tok = _RecordingTokenizer()
get_samples(_args(str(jsonl), {"thinking": True}), tok)
get_samples(_args(str(jsonl), {"thinking": True}), tok) # type: ignore[arg-type]
assert tok.captured_kwargs == {"thinking": True}
@@ -70,6 +70,6 @@ def test_chat_template_kwargs_default_is_noop(tmp_path: Path) -> None:
_write_one(jsonl)
tok = _RecordingTokenizer()
get_samples(_args(str(jsonl), None), tok)
get_samples(_args(str(jsonl), None), tok) # type: ignore[arg-type]
assert tok.captured_kwargs == {}
+29 -15
View File
@@ -4,7 +4,7 @@ import json
from argparse import Namespace
from io import BytesIO
from pathlib import Path
from typing import Any
from typing import Any, cast
import pybase64 as base64
import pytest
@@ -17,6 +17,7 @@ from vllm.benchmarks.lib.endpoint_request_func import (
_get_chat_content,
_get_chat_messages,
)
from vllm.tokenizers import TokenizerLike
pytestmark = pytest.mark.skip_global_cleanup
@@ -31,6 +32,10 @@ class _Tokenizer:
return _TokenizedPrompt(prompt)
def _tokenizer() -> TokenizerLike:
return cast(TokenizerLike, _Tokenizer())
def _write_jsonl(path: Path, rows: list[dict[str, Any]]) -> None:
with path.open("w") as f:
for row in rows:
@@ -92,7 +97,7 @@ def test_get_samples_custom_image_cli_path_supports_multi_image_and_content(
],
)
samples = get_samples(_args_for_custom_image(jsonl), _Tokenizer())
samples = get_samples(_args_for_custom_image(jsonl), _tokenizer())
assert len(samples) == 2
assert samples[0].request_id == "req-0"
@@ -106,6 +111,7 @@ def test_get_samples_custom_image_cli_path_supports_multi_image_and_content(
assert samples[1].multi_modal_data is None
assert isinstance(samples[1].prompt, list)
assert samples[1].prompt[0] == {"type": "text", "text": "Now compare "}
assert isinstance(samples[1].prompt[1], dict)
assert samples[1].prompt[1]["image_url"]["url"] == f"file://{image_c}"
@@ -126,7 +132,7 @@ def test_custom_image_dataset_uses_all_image_files(tmp_path: Path) -> None:
dataset = CustomImageDataset(dataset_path=str(jsonl), disable_shuffle=True)
samples = dataset.sample(
tokenizer=_Tokenizer(),
tokenizer=_tokenizer(),
num_requests=1,
output_len=32,
)
@@ -171,7 +177,7 @@ def test_custom_image_dataset_preserves_interleaved_content_order(
dataset = CustomImageDataset(dataset_path=str(jsonl), disable_shuffle=True)
samples = dataset.sample(
tokenizer=_Tokenizer(),
tokenizer=_tokenizer(),
num_requests=1,
output_len=32,
)
@@ -181,14 +187,18 @@ def test_custom_image_dataset_preserves_interleaved_content_order(
assert sample.multi_modal_data is None
assert sample.prompt_len == 2
assert isinstance(sample.prompt, list)
assert [part["type"] for part in sample.prompt] == [
parts = []
for part in sample.prompt:
assert isinstance(part, dict)
parts.append(part)
assert [part["type"] for part in parts] == [
"text",
"image_url",
"text",
"image_url",
]
assert sample.prompt[1]["image_url"]["url"] == f"file://{image_a}"
assert sample.prompt[3]["image_url"] == {
assert parts[1]["image_url"]["url"] == f"file://{image_a}"
assert parts[3]["image_url"] == {
"url": f"file://{image_b}",
"detail": "low",
}
@@ -223,7 +233,7 @@ def test_custom_image_dataset_wraps_interleaved_content_for_multimodal_chat(
dataset = CustomImageDataset(dataset_path=str(jsonl), disable_shuffle=True)
samples = dataset.sample(
tokenizer=_Tokenizer(),
tokenizer=_tokenizer(),
num_requests=1,
output_len=32,
enable_multimodal_chat=True,
@@ -289,7 +299,7 @@ def test_custom_image_dataset_encodes_image_media_when_requested(
dataset = CustomImageDataset(dataset_path=str(jsonl), disable_shuffle=True)
samples = dataset.sample(
tokenizer=_Tokenizer(),
tokenizer=_tokenizer(),
num_requests=1,
output_len=32,
ensure_client_side_data=True,
@@ -335,7 +345,7 @@ def test_custom_image_dataset_encodes_interleaved_image_media(
dataset = CustomImageDataset(dataset_path=str(jsonl), disable_shuffle=True)
samples = dataset.sample(
tokenizer=_Tokenizer(),
tokenizer=_tokenizer(),
num_requests=1,
output_len=32,
ensure_client_side_data=True,
@@ -343,9 +353,13 @@ def test_custom_image_dataset_encodes_interleaved_image_media(
sample = samples[0]
assert isinstance(sample.prompt, list)
_assert_png_data_url(sample.prompt[1]["image_url"]["url"])
_assert_png_data_url(sample.prompt[2]["image_url"]["url"])
assert sample.prompt[2]["image_url"]["detail"] == "low"
parts = []
for part in sample.prompt:
assert isinstance(part, dict)
parts.append(part)
_assert_png_data_url(parts[1]["image_url"]["url"])
_assert_png_data_url(parts[2]["image_url"]["url"])
assert parts[2]["image_url"]["detail"] == "low"
@pytest.mark.benchmark
@@ -363,7 +377,7 @@ def test_custom_image_dataset_rejects_invalid_image_media(
dataset = CustomImageDataset(dataset_path=str(jsonl), disable_shuffle=True)
with pytest.raises(ValueError, match="Invalid image URL"):
dataset.sample(
tokenizer=_Tokenizer(),
tokenizer=_tokenizer(),
num_requests=1,
output_len=32,
ensure_client_side_data=True,
@@ -380,7 +394,7 @@ def test_custom_image_dataset_rejects_invalid_content_part(
dataset = CustomImageDataset(dataset_path=str(jsonl), disable_shuffle=True)
with pytest.raises(ValueError, match="type 'text', 'image', or 'image_url'"):
dataset.sample(
tokenizer=_Tokenizer(),
tokenizer=_tokenizer(),
num_requests=1,
output_len=32,
)
+2
View File
@@ -37,6 +37,7 @@ def random_dataset_params() -> Params:
def _fingerprint_sample(req: SampleRequest) -> tuple[str, int, int]:
"""Project a SampleRequest into a comparable tuple."""
assert isinstance(req.prompt, str)
return (req.prompt, req.prompt_len, req.expected_output_len)
@@ -153,6 +154,7 @@ def _mm_fingerprint_sample(
- count of multimodal items
- per-item type and URL prefix (e.g., 'data:image/jpeg;base64,')
"""
assert isinstance(req.prompt, str)
items = req.multi_modal_data or []
item_prefixes: list[str] = []
for it in items:
+4 -4
View File
@@ -19,7 +19,7 @@ class _FakeTokenizer(TokenizerLike):
# -- Properties required by TokenizerLike --
@classmethod
def from_pretrained(cls, path_or_repo_id, *a, **kw): # type: ignore[override]
def from_pretrained(cls, path_or_repo_id, *a, **kw):
return cls()
@property
@@ -80,16 +80,16 @@ class _FakeTokenizer(TokenizerLike):
def apply_chat_template(self, messages, **kw): # type: ignore[override]
raise NotImplementedError
def convert_tokens_to_ids(self, tokens): # type: ignore[override]
def convert_tokens_to_ids(self, tokens):
raise NotImplementedError
def convert_tokens_to_string(self, tokens: list[str]) -> str:
raise NotImplementedError
def decode(self, ids, skip_special_tokens: bool = False) -> str: # type: ignore[override]
def decode(self, ids, skip_special_tokens: bool = False) -> str:
raise NotImplementedError
def convert_ids_to_tokens( # type: ignore[override]
def convert_ids_to_tokens(
self, ids, skip_special_tokens: bool = False
) -> list[str]:
raise NotImplementedError
+3 -2
View File
@@ -9,6 +9,7 @@ serve-side dataset coverage.
"""
import subprocess
from argparse import Namespace
from types import SimpleNamespace
import pytest
@@ -289,7 +290,7 @@ def test_to_serve_args_supports_mm_processor_flags() -> None:
explicit 0 instead of coercing it to None (which later crashed
RandomMultiModalDataset.get_prefix on ``None <= 0``).
"""
args = SimpleNamespace(
args = Namespace(
random_input_len=32,
random_output_len=1,
random_prefix_len=0,
@@ -306,7 +307,7 @@ def test_to_serve_args_supports_mm_processor_flags() -> None:
def test_to_serve_args_keeps_legacy_flag_fallback() -> None:
"""Callers that only set the legacy flags still get them mapped."""
args = SimpleNamespace(
args = Namespace(
input_len=256,
output_len=8,
prefix_len=16,