[Security] Reject local verifier references in Speculators metadata (#61587)

Signed-off-by: Juan Pérez de Algaba <jperezde@redhat.com>
Co-authored-by: OpenAI Codex <noreply@openai.com>
This commit is contained in:
Juan Pérez de Algaba
2026-10-14 15:30:20 +00:00
committed by GitHub
co-authored by OpenAI Codex
parent bf6c80c7e8
commit 5d88c034f6
3 changed files with 107 additions and 1 deletions
+14
View File
@@ -14,6 +14,7 @@ import huggingface_hub
import torch
import transformers.configuration_utils as hf_configuration_utils
from huggingface_hub import constants
from huggingface_hub.utils import HFValidationError, validate_repo_id
from safetensors.torch import _TYPES as _SAFETENSORS_TO_TORCH_DTYPE
from transformers import GenerationConfig, PreTrainedConfig
from transformers.configuration_utils import ALLOWED_LAYER_TYPES
@@ -844,6 +845,19 @@ def maybe_override_with_speculators(
# Override model and tokenizer with the verifier model from config
verifier_model = speculators_config["verifier"]["name_or_path"]
verifier_error = (
"Speculators verifier must name a remote model repository. "
"Select local verifiers explicitly with --model and --speculative-config."
)
if not isinstance(verifier_model, str):
raise ValueError(verifier_error)
try:
validate_repo_id(verifier_model)
except HFValidationError as exc:
raise ValueError(verifier_error) from exc
verifier_path = Path(verifier_model)
if verifier_path.exists() or verifier_path.is_symlink():
raise ValueError(verifier_error)
model = tokenizer = verifier_model
return model, tokenizer, speculative_config