[Bugfix] Add proper comparison for package versions (#22314)

Signed-off-by: Syed Muhammad Bin Asif <syedmba7@connect.hku.hk>
This commit is contained in:
Syed Muhammad Bin Asif
2025-08-06 20:31:03 -07:00
committed by GitHub
parent 5e9455ae8f
commit 609b533cb6
13 changed files with 40 additions and 16 deletions
@@ -3,6 +3,7 @@
from typing import Optional
import torch
from packaging import version
from vllm.platforms import current_platform
from vllm.scalar_type import ScalarType, scalar_types
@@ -75,7 +76,8 @@ def _check_bitblas_supported(
# Finally, check if bitblas is installed
try:
import bitblas
if bitblas.__version__ < MINIMUM_BITBLAS_VERSION:
if version.parse(
bitblas.__version__) < version.parse(MINIMUM_BITBLAS_VERSION):
raise ImportError("bitblas version is wrong. Please "
f"install bitblas>={MINIMUM_BITBLAS_VERSION}")
except ImportError:
@@ -4,6 +4,7 @@
from typing import Callable, Optional, Union
import torch
from packaging import version
from vllm import _custom_ops as ops
from vllm import envs
@@ -21,8 +22,8 @@ TORCH_DEVICE_IDENTITY = None
# torch._scaled_mm rowwise feature.
# The condition is determined once as the operations
# are time consuming.
USE_ROWWISE_TORCH_SCALED_MM = (current_platform.is_rocm()
and torch.__version__[0:3] >= "2.7"
USE_ROWWISE_TORCH_SCALED_MM = (current_platform.is_rocm() and version.parse(
torch.__version__) >= version.parse("2.7")
and current_platform.has_device_capability(94))