[Build] Define _USE_MATH_DEFINES for FlashMLA targets (#54007)
Signed-off-by: arcusbuilds <srijankeshri007@gmail.com> Co-authored-by: Shengqi Chen <harry-chen@outlook.com>
This commit is contained in:
co-authored by
Shengqi Chen
parent
33fa95a0cf
commit
6b153463a8
@@ -186,6 +186,15 @@ if(FLASH_MLA_ARCHS)
|
|||||||
if(VLLM_GPU_LANG STREQUAL "CUDA")
|
if(VLLM_GPU_LANG STREQUAL "CUDA")
|
||||||
target_compile_definitions(_flashmla_extension_C PRIVATE USE_CUDA)
|
target_compile_definitions(_flashmla_extension_C PRIVATE USE_CUDA)
|
||||||
endif()
|
endif()
|
||||||
|
|
||||||
|
# FlashMLA's sources use M_LOG2E from <cmath>. MSVC's UCRT only defines the
|
||||||
|
# M_* constants when _USE_MATH_DEFINES is set before <cmath> is first
|
||||||
|
# included, so define it for both targets on MSVC. Scoped to MSVC so the
|
||||||
|
# compile flags (and build caches) on other platforms stay unchanged.
|
||||||
|
if(MSVC)
|
||||||
|
target_compile_definitions(_flashmla_C PRIVATE _USE_MATH_DEFINES)
|
||||||
|
target_compile_definitions(_flashmla_extension_C PRIVATE _USE_MATH_DEFINES)
|
||||||
|
endif()
|
||||||
else()
|
else()
|
||||||
message(STATUS "FlashMLA will not compile: unsupported CUDA architecture ${CUDA_ARCHS}")
|
message(STATUS "FlashMLA will not compile: unsupported CUDA architecture ${CUDA_ARCHS}")
|
||||||
# Create empty targets for setup.py on unsupported systems
|
# Create empty targets for setup.py on unsupported systems
|
||||||
|
|||||||
Reference in New Issue
Block a user