[Security] Bound decoded and downloaded media per request (#61226)

Signed-off-by: juanpas97 <juan.perezalgaba@gmail.com>
Signed-off-by: Juan Pérez de Algaba <jperezde@redhat.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
This commit is contained in:
Juan Pérez de Algaba
2026-10-13 10:17:14 +00:00
committed by GitHub
co-authored by OpenAI Codex
parent 877f6df889
commit 7173c64e2e
16 changed files with 565 additions and 50 deletions
+50 -1
View File
@@ -9,7 +9,13 @@ from unittest.mock import AsyncMock, patch
import pytest
import vllm.envs as envs
from vllm.connections import HTTPConnection, HTTPResponseSizeExceededError
from vllm.connections import (
HTTPConnection,
HTTPResponseSizeExceededError,
MediaRequestDownloadBudget,
)
pytestmark = [pytest.mark.cpu_test, pytest.mark.skip_global_cleanup]
_ONE_MIB = 1024 * 1024
_SMALL_BODY = b"a" * (_ONE_MIB // 2)
@@ -150,6 +156,49 @@ async def test_async_get_bytes_with_limit_streams_instead_of_materializing() ->
assert response.content.iterated == 2
def test_request_download_budget_counts_across_responses(
monkeypatch: pytest.MonkeyPatch,
) -> None:
monkeypatch.setattr(envs, "VLLM_MAX_MEDIA_REQUEST_DOWNLOAD_SIZE_MB", 1)
budget = MediaRequestDownloadBudget()
connection = HTTPConnection()
first = _SyncResponse([b"a" * (3 * _ONE_MIB // 4)])
second = _SyncResponse([b"b" * (_ONE_MIB // 2)])
with patch.object(connection, "get_response", side_effect=[first, second]):
connection.get_bytes("http://example.com/one", request_budget=budget)
with pytest.raises(ValueError, match="VLLM_MAX_MEDIA_REQUEST_DOWNLOAD_SIZE_MB"):
connection.get_bytes("http://example.com/two", request_budget=budget)
assert budget.used == 3 * _ONE_MIB // 4
assert second.iterated == 1
@pytest.mark.asyncio
async def test_async_request_download_budget_counts_across_responses(
monkeypatch: pytest.MonkeyPatch,
) -> None:
monkeypatch.setattr(envs, "VLLM_MAX_MEDIA_REQUEST_DOWNLOAD_SIZE_MB", 1)
budget = MediaRequestDownloadBudget()
connection = HTTPConnection()
first = _AsyncResponse([b"a" * (3 * _ONE_MIB // 4)])
second = _AsyncResponse([b"b" * (_ONE_MIB // 2)])
with patch.object(
connection, "get_async_response", new=AsyncMock(side_effect=[first, second])
):
await connection.async_get_bytes(
"http://example.com/one", request_budget=budget
)
with pytest.raises(ValueError, match="VLLM_MAX_MEDIA_REQUEST_DOWNLOAD_SIZE_MB"):
await connection.async_get_bytes(
"http://example.com/two", request_budget=budget
)
assert budget.used == 3 * _ONE_MIB // 4
assert second.content.iterated == 1
def test_get_bytes_rejects_content_length_over_limit(
monkeypatch: pytest.MonkeyPatch, local_media_server: str
) -> None: