From 7746961277ac45df9c5d2b1341af649cdbdf459c Mon Sep 17 00:00:00 2001 From: qli88 Date: Wed, 15 Jul 2026 21:23:03 -0500 Subject: [PATCH] [CI] Fix flaky lora test (#47375) Signed-off-by: Qiang Li Signed-off-by: qli88 --- tests/lora/test_gptoss_tp.py | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/tests/lora/test_gptoss_tp.py b/tests/lora/test_gptoss_tp.py index b9f99d7a8c..0f0d807441 100644 --- a/tests/lora/test_gptoss_tp.py +++ b/tests/lora/test_gptoss_tp.py @@ -42,6 +42,14 @@ EXPECTED_LORA_OUTPUT = [ ] +def reformat(text: str) -> str: + # Remove all spaces immediately before or after comma + text = ",".join(map(str.strip, text.split(","))) + # Remove duplicated blank spaces + text = " ".join(map(str.strip, text.split())) + return text + + def generate_and_test(llm: vllm.LLM, lora_path: str, lora_id: int) -> None: prompts = [ PROMPT_TEMPLATE.format( @@ -68,13 +76,18 @@ def generate_and_test(llm: vllm.LLM, lora_path: str, lora_id: int) -> None: generated_texts.append(generated_text) print(f"Prompt: {prompt!r}, Generated text: {generated_text!r}") for i in range(len(EXPECTED_LORA_OUTPUT)): - generated = " ".join(generated_texts[i].split()) - expected = " ".join(EXPECTED_LORA_OUTPUT[i].split()) - assert generated.startswith(expected) + # The generated text may have different numbers of blank space, + # so reformat to compare. + compactGeneratedStr = reformat(generated_texts[i]) + compactExpectedStr = reformat(EXPECTED_LORA_OUTPUT[i]) + if not generated_texts[i].startswith( + EXPECTED_LORA_OUTPUT[i] + ) and not compactGeneratedStr.startswith(compactExpectedStr): + raise AssertionError( + f"Generated: {generated_texts[i]}, Expected: {EXPECTED_LORA_OUTPUT[i]}" + ) -# TODO: make the Mxfp4MoeBackend.TRITON spawn-safe. -# For now just use TRITON_UNFUSED kernel @pytest.mark.parametrize( "mxfp4_use_marlin", [