[NIXL] Drop unreachable producer-side notif counting in push mode (#62210)

Signed-off-by: David Cheung <d7cheung@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: vllm-agent <claw@inferact.ai>
This commit is contained in:
David Cheung
2026-10-17 21:24:35 +00:00
committed by GitHub
co-authored by Claude Opus 5.5 vllm-agent
parent 255f14599e
commit 7879f3687b
2 changed files with 26 additions and 59 deletions
@@ -929,14 +929,8 @@ class TestPushWriterNotifs:
notif_msg = f"{request_id}:1".encode()
w._pending_completion_notifs.put(notif_msg)
# transfer_topo is consulted only for the producer-side path; we
# make it a MagicMock because the D-side branch returns early.
w.transfer_topo = MagicMock()
w._get_new_notifs()
notified = w._get_new_notifs()
# Notif consumed; D-side just touches _recving_transfers.
assert notified == set()
assert request_id in w._recving_transfers
def test_get_transfer_results_evicts_completed_state(self):
@@ -1352,12 +1346,10 @@ class TestPushWriterNegative:
logger=("vllm.distributed.kv_transfer.kv_connector.v1.nixl.push_worker"),
)
w = _StubWriterWorker.fresh()
w.transfer_topo = MagicMock()
# Forward a completion notif for an unknown request_id.
w._pending_completion_notifs.put(b"never-heard-of-you:1")
notified = w._get_new_notifs()
assert notified == set()
w._get_new_notifs()
# Did not register anywhere.
assert "never-heard-of-you" not in w._recving_transfers
assert w.xfer_stats.data["num_notifications_after_expiry"] == [1]
@@ -1381,7 +1373,6 @@ class TestPushWriterNegative:
leases of tracked P-side requests on the engine main thread, and
ignore request IDs that aren't being tracked."""
w = _StubWriterWorker.fresh()
w.transfer_topo = MagicMock()
# _handle_heartbeat reads ``self._lease_extension`` (set in the
# real ``__init__``).
w._lease_extension = 10
@@ -1395,8 +1386,7 @@ class TestPushWriterNegative:
# and another tracked one.
w._pending_completion_notifs.put(b"HB:req-a,req-unknown,req-b")
notified = w._get_new_notifs()
assert notified == set()
w._get_new_notifs()
# Tracked leases were renewed strictly forward in time.
now = time.perf_counter()
@@ -1421,20 +1411,19 @@ class TestPushPipelineParallel:
"""Each PP stage WRITEs its own layers and sends one notif; D must
collect pp_size notifs before reporting the recv done."""
w = _StubWriterWorker.fresh()
w.transfer_topo = MagicMock()
request_id = "req-pp-2"
w._recving_metadata[request_id] = MagicMock(pp_size=2)
notif = f"{request_id}:1".encode()
# First stage: counted, not yet done.
w._pending_completion_notifs.put(notif)
assert w._get_new_notifs() == set()
w._get_new_notifs()
assert request_id not in w._recving_transfers
assert w.consumer_notification_counts_by_req[request_id] == 1
# Second (final) stage: now reported done.
w._pending_completion_notifs.put(notif)
assert w._get_new_notifs() == set()
w._get_new_notifs()
assert request_id in w._recving_transfers
assert request_id not in w.consumer_notification_counts_by_req