From 7a29a3c54cc338b0103005978f38764e40299572 Mon Sep 17 00:00:00 2001 From: Jonguk Cheong Date: Sun, 26 Jul 2026 14:21:52 +0900 Subject: [PATCH] [Bugfix][KV Offload] Namespace persistent cache by model runner (#49440) Signed-off-by: Jonguk Cheong Co-authored-by: Or Ozeri --- tests/v1/kv_offload/test_file_mapper.py | 21 ++++++++++++++++++++- vllm/v1/kv_offload/file_mapper.py | 2 ++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/tests/v1/kv_offload/test_file_mapper.py b/tests/v1/kv_offload/test_file_mapper.py index 6c11f2d465..c2c4427e18 100644 --- a/tests/v1/kv_offload/test_file_mapper.py +++ b/tests/v1/kv_offload/test_file_mapper.py @@ -85,7 +85,7 @@ def test_get_file_name_full_structure(): path = fm.get_file_name(key) expected_path = ( - "/tmp/cache/test-model_42b94bdc9933_r3/000/10_g2/0001020304050607.bin" + "/tmp/cache/test-model_de3bba26cf36_r3/000/10_g2/0001020304050607.bin" ) assert path == expected_path @@ -119,6 +119,7 @@ def test_get_run_config_fields(): } ], "inference_engine": "vllm", + "parallel_agnostic": False, } @@ -164,6 +165,7 @@ def test_parallel_agnostic_collapses_namespace_when_config_allows(): assert fm.fields["pcp_size"] == 1 assert fm.fields["dcp_size"] == 1 assert fm.rank == 0 + assert "parallel_agnostic" not in fm.fields def test_parallel_agnostic_ignored_when_config_disallows(): @@ -175,6 +177,7 @@ def test_parallel_agnostic_ignored_when_config_disallows(): ) assert fm.fields["tp_size"] == 2 assert fm.rank == 1 + assert fm.fields["parallel_agnostic"] is False def test_namespace_kept_without_parallel_agnostic_opt_in(): @@ -186,3 +189,19 @@ def test_namespace_kept_without_parallel_agnostic_opt_in(): ) assert fm.fields["tp_size"] == 2 assert fm.rank == 1 + assert fm.fields["parallel_agnostic"] is False + + +def test_parallel_agnostic_separates_persistent_layouts(): + agnostic = make_mapper_from_offloading_spec( + is_parallelism_agnostic=True, + parallel_agnostic=True, + ) + specific = make_mapper_from_offloading_spec( + is_parallelism_agnostic=False, + parallel_agnostic=True, + ) + + assert agnostic.base_path != specific.base_path + assert "parallel_agnostic" not in agnostic.fields + assert specific.fields["parallel_agnostic"] is False diff --git a/vllm/v1/kv_offload/file_mapper.py b/vllm/v1/kv_offload/file_mapper.py index b85d4d0697..8e8c19d53d 100644 --- a/vllm/v1/kv_offload/file_mapper.py +++ b/vllm/v1/kv_offload/file_mapper.py @@ -58,6 +58,8 @@ class FileMapper: "kv_cache_groups": kv_cache_groups or [], "inference_engine": inference_engine, } + if not parallel_agnostic: + self.fields["parallel_agnostic"] = False self.base_path: str = self._compute_base_path(root_dir, self.fields) @classmethod