[Frontend] Make finish_reason and Responses item status truthful (#59324)

Signed-off-by: Flora Feng <4florafeng@gmail.com>
Signed-off-by: sfeng33 <4florafeng@gmail.com>
Co-authored-by: Chauncey <chaunceyjiang@gmail.com>
This commit is contained in:
Flora Feng
2026-10-15 10:12:02 +01:00
committed by GitHub
co-authored by Chauncey
parent 427915bed2
commit 80dd705c1d
14 changed files with 421 additions and 62 deletions
@@ -1289,7 +1289,15 @@ class TestDerenderChatStreamParsed:
assert state.last_tool_call_ids == [first_id]
@pytest.mark.asyncio
async def test_finish_reason_rewritten_to_tool_calls(self, parsed_derenderer):
@pytest.mark.parametrize(
("engine_finish_reason", "expected_finish_reason"),
[("stop", "tool_calls"), ("length", "length")],
)
async def test_finish_reason_rewritten_to_tool_calls(
self, parsed_derenderer, engine_finish_reason, expected_finish_reason
):
"""A streamed tool call is reported as ``tool_calls`` only at a
natural stop; a ``length`` cut must stay visible."""
chat_request = _chat_request(
tools=[{"type": "function", "function": {"name": "get_weather"}}],
tool_choice="auto",
@@ -1297,11 +1305,12 @@ class TestDerenderChatStreamParsed:
chunk, _ = await parsed_derenderer.derender_chat_stream(
model=MODEL_NAME,
generate_chunk=_make_stream_chunk(
[_FakeParser.TOOL_START, _FakeParser.TOOL_ARG], finish_reason="stop"
[_FakeParser.TOOL_START, _FakeParser.TOOL_ARG],
finish_reason=engine_finish_reason,
),
chat_request=chat_request,
)
assert chunk.choices[0].finish_reason == "tool_calls"
assert chunk.choices[0].finish_reason == expected_finish_reason
@pytest.mark.asyncio
async def test_finish_reason_stop_for_named_tool_choice(self, parsed_derenderer):