[Tool] adjust_request to reasoning parser, and Gemma4 fixes (#39027)
Signed-off-by: Ben Browning <bbrownin@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
co-authored by
Claude Opus 4.6
Cursor
parent
e24e0a43a4
commit
8477fe427d
@@ -114,6 +114,19 @@ class TestParseGemma4Args:
|
||||
result = _parse_gemma4_args("key:")
|
||||
assert result == {"key": ""}
|
||||
|
||||
def test_empty_value_partial_withheld(self):
|
||||
"""Key with no value is withheld in partial mode to avoid premature emission."""
|
||||
result = _parse_gemma4_args("key:", partial=True)
|
||||
assert result == {}
|
||||
# also with a space after the colon
|
||||
result = _parse_gemma4_args("key: ", partial=True)
|
||||
assert result == {}
|
||||
|
||||
def test_empty_value_after_other_keys_partial_withheld(self):
|
||||
"""Trailing key with no value is withheld; earlier keys are kept."""
|
||||
result = _parse_gemma4_args('name:<|"|>test<|"|>,flag:', partial=True)
|
||||
assert result == {"name": "test"}
|
||||
|
||||
|
||||
class TestParseGemma4Array:
|
||||
def test_string_array(self):
|
||||
@@ -636,3 +649,30 @@ class TestStreamingExtraction:
|
||||
' <meta charset="UTF-8">\n'
|
||||
' <meta name="viewport" content="width=device-width">\n'
|
||||
)
|
||||
|
||||
def test_streaming_trailing_bare_bool_not_duplicated(self, parser, mock_request):
|
||||
"""Trailing bare boolean must not be streamed twice."""
|
||||
chunks = [
|
||||
"<|tool_call>",
|
||||
"call:Edit{",
|
||||
'file_path:<|"|>src/env.py<|"|>,',
|
||||
'old_string:<|"|>old_val<|"|>,',
|
||||
'new_string:<|"|>new_val<|"|>,',
|
||||
"replace_all:",
|
||||
"false}",
|
||||
"<tool_call|>",
|
||||
]
|
||||
|
||||
results = self._simulate_streaming(parser, mock_request, chunks)
|
||||
args_text = self._collect_arguments(results)
|
||||
assert args_text, "No arguments were streamed"
|
||||
|
||||
parsed_args = json.loads(args_text)
|
||||
assert parsed_args == {
|
||||
"file_path": "src/env.py",
|
||||
"old_string": "old_val",
|
||||
"new_string": "new_val",
|
||||
"replace_all": False,
|
||||
}
|
||||
|
||||
assert args_text.count("replace_all") == 1
|
||||
|
||||
Reference in New Issue
Block a user