Add pydocstyle to the ruff rules (#52136)
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Harry Mellor <hej.mellor@gmail.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
804e5377aa
commit
8c1557a79c
@@ -57,7 +57,8 @@ class TestMaybeRemapKvScaleName:
|
||||
|
||||
def test_qkv_proj_k_scale(self):
|
||||
"""Qwen3-MoE / llm-compressor format: qkv_proj.k_scale -> attn.k_scale
|
||||
Regression test for https://github.com/vllm-project/vllm/issues/25047"""
|
||||
Regression test for https://github.com/vllm-project/vllm/issues/25047
|
||||
"""
|
||||
result = maybe_remap_kv_scale_name(
|
||||
"model.layers.0.self_attn.qkv_proj.k_scale", self.PARAMS_DICT
|
||||
)
|
||||
@@ -65,35 +66,36 @@ class TestMaybeRemapKvScaleName:
|
||||
|
||||
def test_qkv_proj_v_scale(self):
|
||||
"""Qwen3-MoE / llm-compressor format: qkv_proj.v_scale -> attn.v_scale
|
||||
Regression test for https://github.com/vllm-project/vllm/issues/25047"""
|
||||
Regression test for https://github.com/vllm-project/vllm/issues/25047
|
||||
"""
|
||||
result = maybe_remap_kv_scale_name(
|
||||
"model.layers.0.self_attn.qkv_proj.v_scale", self.PARAMS_DICT
|
||||
)
|
||||
assert result == "model.layers.0.self_attn.attn.v_scale"
|
||||
|
||||
def test_modelopt_k_proj_k_scale(self):
|
||||
"""ModelOpt format: k_proj.k_scale -> attn.k_scale"""
|
||||
"""ModelOpt format: k_proj.k_scale -> attn.k_scale."""
|
||||
result = maybe_remap_kv_scale_name(
|
||||
"model.layers.0.self_attn.k_proj.k_scale", self.PARAMS_DICT
|
||||
)
|
||||
assert result == "model.layers.0.self_attn.attn.k_scale"
|
||||
|
||||
def test_modelopt_v_proj_v_scale(self):
|
||||
"""ModelOpt format: v_proj.v_scale -> attn.v_scale"""
|
||||
"""ModelOpt format: v_proj.v_scale -> attn.v_scale."""
|
||||
result = maybe_remap_kv_scale_name(
|
||||
"model.layers.0.self_attn.v_proj.v_scale", self.PARAMS_DICT
|
||||
)
|
||||
assert result == "model.layers.0.self_attn.attn.v_scale"
|
||||
|
||||
def test_deprecated_kv_scale(self):
|
||||
"""Old format: kv_scale -> attn.k_scale (deprecated)"""
|
||||
"""Old format: kv_scale -> attn.k_scale (deprecated)."""
|
||||
result = maybe_remap_kv_scale_name(
|
||||
"model.layers.0.self_attn.kv_scale", self.PARAMS_DICT
|
||||
)
|
||||
assert result == "model.layers.0.self_attn.attn.k_scale"
|
||||
|
||||
def test_default_bare_k_scale(self):
|
||||
"""Default format: .k_scale -> .attn.k_scale"""
|
||||
"""Default format: .k_scale -> .attn.k_scale."""
|
||||
result = maybe_remap_kv_scale_name(
|
||||
"model.layers.0.self_attn.k_scale", self.PARAMS_DICT
|
||||
)
|
||||
@@ -108,7 +110,8 @@ class TestMaybeRemapKvScaleName:
|
||||
def test_nvfp4_modelopt_k_proj_k_scale(self):
|
||||
"""ModelOpt NVFP4 format (e.g. nvidia/Qwen3-30B-A3B-NVFP4):
|
||||
k_proj.k_scale -> attn.k_scale.
|
||||
Validates that NVFP4 checkpoints are not broken by this change."""
|
||||
Validates that NVFP4 checkpoints are not broken by this change.
|
||||
"""
|
||||
result = maybe_remap_kv_scale_name(
|
||||
"model.layers.0.self_attn.k_proj.k_scale", self.PARAMS_DICT
|
||||
)
|
||||
@@ -117,7 +120,8 @@ class TestMaybeRemapKvScaleName:
|
||||
def test_nvfp4_modelopt_v_proj_v_scale(self):
|
||||
"""ModelOpt NVFP4 format (e.g. nvidia/Qwen3-30B-A3B-NVFP4):
|
||||
v_proj.v_scale -> attn.v_scale.
|
||||
Validates that NVFP4 checkpoints are not broken by this change."""
|
||||
Validates that NVFP4 checkpoints are not broken by this change.
|
||||
"""
|
||||
result = maybe_remap_kv_scale_name(
|
||||
"model.layers.0.self_attn.v_proj.v_scale", self.PARAMS_DICT
|
||||
)
|
||||
@@ -125,7 +129,8 @@ class TestMaybeRemapKvScaleName:
|
||||
|
||||
def test_qwen3_vl_moe_qkv_proj_k_scale(self):
|
||||
"""Qwen3-VL-MoE uses the same fused qkv_proj naming as Qwen3-MoE.
|
||||
Regression test for qwen3_vl_moe.py fix (same bug as #25047)."""
|
||||
Regression test for qwen3_vl_moe.py fix (same bug as #25047).
|
||||
"""
|
||||
result = maybe_remap_kv_scale_name(
|
||||
"model.layers.0.self_attn.qkv_proj.k_scale", self.PARAMS_DICT
|
||||
)
|
||||
@@ -133,7 +138,8 @@ class TestMaybeRemapKvScaleName:
|
||||
|
||||
def test_qwen3_vl_moe_qkv_proj_v_scale(self):
|
||||
"""Qwen3-VL-MoE uses the same fused qkv_proj naming as Qwen3-MoE.
|
||||
Regression test for qwen3_vl_moe.py fix (same bug as #25047)."""
|
||||
Regression test for qwen3_vl_moe.py fix (same bug as #25047).
|
||||
"""
|
||||
result = maybe_remap_kv_scale_name(
|
||||
"model.layers.0.self_attn.qkv_proj.v_scale", self.PARAMS_DICT
|
||||
)
|
||||
@@ -175,7 +181,8 @@ class TestKvCacheScaleMapper:
|
||||
"""The `WeightsMapper` returned by `get_cache_scale_mapper` replaces the
|
||||
per-model `maybe_remap_kv_scale_name` calls. It must remap the same set of
|
||||
checkpoint formats (the non-`params_dict`-dependent ones) and be idempotent
|
||||
so it composes safely with a model's own qkv/gate_up `hf_to_vllm_mapper`."""
|
||||
so it composes safely with a model's own qkv/gate_up `hf_to_vllm_mapper`.
|
||||
"""
|
||||
|
||||
def _mapper(self):
|
||||
# `get_cache_scale_mapper` does not use `self`; call it on the base
|
||||
@@ -265,7 +272,8 @@ class TestKvCacheScaleMapper:
|
||||
def test_composes_with_qkv_mapper(self):
|
||||
"""Applied together with a model's qkv/gate_up mapper, the regex scale
|
||||
rules run before the substr rename, so scales are normalized to `.attn.`
|
||||
and regular projections are still fused correctly."""
|
||||
and regular projections are still fused correctly.
|
||||
"""
|
||||
from vllm.model_executor.models.utils import WeightsMapper
|
||||
|
||||
model_mapper = WeightsMapper(
|
||||
|
||||
Reference in New Issue
Block a user