Add pydocstyle to the ruff rules (#52136)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <hej.mellor@gmail.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Harry Mellor
2026-09-16 16:44:29 +00:00
committed by GitHub
co-authored by Claude Opus 5
parent 804e5377aa
commit 8c1557a79c
2002 changed files with 15024 additions and 14269 deletions
+14 -8
View File
@@ -54,7 +54,8 @@ def test_audio_media_io_load_base64(dummy_audio_bytes):
def test_audio_media_io_load_base64_rejects_malformed(dummy_audio_bytes):
"""Malformed base64 must surface as a ValueError so the server answers 400.
Without strict decoding the bad characters are dropped, the garbage reaches
libsndfile, and the client gets a 500 instead."""
libsndfile, and the client gets a 500 instead.
"""
encoded = base64.b64encode(dummy_audio_bytes).decode("utf-8")
malformed = encoded[:8] + "!!!@@@###" + encoded[8:]
@@ -133,7 +134,8 @@ def test_small_file_passes_memory_guard():
def test_memory_guard_rejects_large_allocation():
"""A file whose frames*channels*4 exceeds the byte limit must be
rejected before allocating the buffer."""
rejected before allocating the buffer.
"""
# 100_000 frames * 8 channels * 4 bytes = 3.2 MB
payload = _make_flac_bytes(frames=100_000, channels=8, samplerate=48000)
# Set limit to 1 MiB — should reject
@@ -148,7 +150,8 @@ def test_memory_guard_rejects_large_allocation():
def test_forged_samplerate_rejected_by_memory_guard():
"""The PoC scenario: high sample rate fools the duration guard but
the memory guard catches the large frame*channel allocation."""
the memory guard catches the large frame*channel allocation.
"""
# Forged high sample rate: 655350 Hz, 8 channels, 1M frames
# Duration guard sees: 1_000_000 / 655_350 = 1.5s → passes
# Memory: 1_000_000 * 8 * 4 = 32 MB
@@ -209,7 +212,8 @@ def test_load_audio_unknown_backend_rejected(dummy_audio_bytes):
def test_load_audio_auto_falls_back_without_torchcodec(dummy_audio_bytes):
"""`auto` must fall back to the soundfile → PyAV chain when torchcodec
is not importable."""
is not importable.
"""
ref_audio, ref_sr = load_audio_soundfile(BytesIO(dummy_audio_bytes), sr=None)
with patch.object(audio_module, "load_audio_torchcodec", side_effect=ImportError):
audio, sr = load_audio(BytesIO(dummy_audio_bytes), sr=None, backend="auto")
@@ -218,8 +222,9 @@ def test_load_audio_auto_falls_back_without_torchcodec(dummy_audio_bytes):
def test_load_audio_auto_falls_back_without_ffmpeg(dummy_audio_bytes):
"""torchcodec installed but system ffmpeg missing (`AudioDecoder is None`)
must surface as ImportError so `auto` falls back to soundfile → PyAV."""
"""Torchcodec installed but system ffmpeg missing (`AudioDecoder is None`)
must surface as ImportError so `auto` falls back to soundfile → PyAV.
"""
ref_audio, ref_sr = load_audio_soundfile(BytesIO(dummy_audio_bytes), sr=None)
with patch.object(audio_module, "AudioDecoder", None):
with pytest.raises(ImportError, match="torchcodec audio backend"):
@@ -232,9 +237,10 @@ def test_load_audio_auto_falls_back_without_ffmpeg(dummy_audio_bytes):
def test_load_audio_auto_falls_back_when_libtorchcodec_unloadable(
dummy_audio_bytes,
):
"""torchcodec loads its ffmpeg-backed core lazily at decoder construction;
"""Torchcodec loads its ffmpeg-backed core lazily at decoder construction;
a "Could not load libtorchcodec" RuntimeError there (no system ffmpeg)
must also surface as ImportError so `auto` falls back."""
must also surface as ImportError so `auto` falls back.
"""
class _UnloadableDecoder:
def __init__(self, *args, **kwargs):