Add pydocstyle to the ruff rules (#52136)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <hej.mellor@gmail.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Harry Mellor
2026-09-16 16:44:29 +00:00
committed by GitHub
co-authored by Claude Opus 5
parent 804e5377aa
commit 8c1557a79c
2002 changed files with 15024 additions and 14269 deletions
+25 -20
View File
@@ -842,8 +842,7 @@ def test_video_processor_from_model_repo(
def test_video_backend_handles_broken_frames(monkeypatch: pytest.MonkeyPatch):
"""
Regression test for handling videos with broken frames.
"""Regression test for handling videos with broken frames.
This test uses a pre-corrupted video file (assets/corrupted.mp4) that
contains broken frames to verify the video loader handles
them gracefully without crashing and returns accurate metadata.
@@ -882,8 +881,7 @@ def test_video_backend_handles_broken_frames(monkeypatch: pytest.MonkeyPatch):
def test_video_backend_handles_edit_list_trimmed_video(
monkeypatch: pytest.MonkeyPatch,
):
"""
An mp4 edit list (e.g. from a lossless ``ffmpeg -ss ... -c copy`` cut)
"""An mp4 edit list (e.g. from a lossless ``ffmpeg -ss ... -c copy`` cut)
hides the decode lead-in: the header still counts every physical sample
while sequential decode only yields the visible frames. Sampling over the
header count used to collapse such videos to the few indices below the
@@ -923,8 +921,7 @@ def test_video_backend_handles_edit_list_trimmed_video(
def test_video_recovery_simulated_failures(monkeypatch: pytest.MonkeyPatch):
"""
Test that frame recovery correctly uses the next valid frame when
"""Test that frame recovery correctly uses the next valid frame when
target frames fail to load.
Uses corrupted.mp4 and mocks VideoCapture.grab() to fail on specific
@@ -1019,8 +1016,7 @@ def test_video_recovery_simulated_failures(monkeypatch: pytest.MonkeyPatch):
def test_video_recovery_with_corrupted_file(monkeypatch: pytest.MonkeyPatch):
"""
Test frame recovery with an actual corrupted video file using sparse sampling.
"""Test frame recovery with an actual corrupted video file using sparse sampling.
This test uses corrupted.mp4 which has genuine H.264 codec errors on
frame 17. With num_frames=8, the target frames are [0, 3, 7, 10, 14, 17, 21, 25].
@@ -1088,8 +1084,7 @@ def test_video_recovery_with_corrupted_file(monkeypatch: pytest.MonkeyPatch):
def test_video_recovery_dynamic_backend(monkeypatch: pytest.MonkeyPatch):
"""
Test that frame_recovery works with the dynamic video backend.
"""Test that frame_recovery works with the dynamic video backend.
The dynamic backend samples frames based on fps/duration rather than
loading all frames. This test verifies recovery works in that context.
@@ -1219,7 +1214,8 @@ def test_torchcodec_backend_rejects_frame_recovery(dummy_video_path):
@pytest.mark.skipif(not current_platform.is_cuda(), reason="Requires CUDA")
def test_torchcodec_backend_cuda_decodes_on_gpu(dummy_video_path):
"""With device="cuda", torchcodec decodes via NVDEC and keeps the frames
on the GPU instead of returning a host-side numpy array."""
on the GPU instead of returning a host-side numpy array.
"""
pytest.importorskip("torchcodec")
with open(dummy_video_path, "rb") as f:
@@ -1512,7 +1508,8 @@ def test_glm46v_duration_estimation_from_fps():
class TestGLMGASamplingCaps:
"""Regression tests for GHSA-58v5-2m8f-94pr: request-controlled fps
and max_frames must not create intermediate allocations larger than
the actual frame count."""
the actual frame count.
"""
@staticmethod
def _source(
@@ -1566,7 +1563,8 @@ def test_glm5next_backend_selected_for_processor():
"""Glm5NextVideoProcessor maps to the glm5next loader so only the
sampled frames are decoded instead of the whole container. Both the
borrowed-config spelling and the dedicated Glm5next class name (landing
with the new checkpoint) must resolve."""
with the new checkpoint) must resolve.
"""
for name in ("Glm5NextVideoProcessor", "Glm5nextVideoProcessor"):
assert VIDEO_LOADER_REGISTRY.get_backend_for_video_processor(name) == "glm5next"
@@ -1588,7 +1586,8 @@ def test_glm5next_backend_indices_match_sampler(
total_frames, original_fps, duration, fps, max_frames
):
"""The loader must select exactly the frames the processor's sampler
would, with target.fps mapping onto the raw-fps override."""
would, with target.fps mapping onto the raw-fps override.
"""
from vllm.transformers_utils.processors.glm5next import (
glm_sample_frame_indices,
)
@@ -1616,7 +1615,8 @@ def test_glm5next_backend_indices_match_sampler(
def test_glm5next_backend_metadata_contract():
"""create_hf_metadata reports the subset so the processor skips
re-sampling (do_sample_frames=False) and keeps the original totals."""
re-sampling (do_sample_frames=False) and keeps the original totals.
"""
source = VideoSourceMetadata(total_frames_num=900, original_fps=30.0, duration=30.0)
target = VideoTargetMetadata(num_frames=-1, fps=-1, max_duration=-1)
indices = Glm5NextVideoBackend.compute_frames_index_to_sample(source, target)
@@ -1645,7 +1645,8 @@ def test_glm5next_backend_metadata_contract():
def _write_gray_video(tmp_path, total_frames, fps, size=(32, 32)):
"""Synthetic clip whose frame i is flat gray level i (near-lossless under
mp4v), so a decoded frame's level maps back to its source index."""
mp4v), so a decoded frame's level maps back to its source index.
"""
cv2 = pytest.importorskip("cv2")
path = tmp_path / f"gray_{total_frames}_{fps}.mp4"
@@ -1686,7 +1687,8 @@ class _CountingCap:
def test_glm5next_backend_codec_parity(tmp_path, backend):
"""Every codec samples the same GLM indices and decodes the same
frames; the OpenCV seek reader and torchcodec batched index-exact decode
must agree."""
must agree.
"""
if backend == "torchcodec":
pytest.importorskip("torchcodec")
@@ -1716,7 +1718,8 @@ def test_glm5next_backend_codec_parity(tmp_path, backend):
def test_glm5next_backend_decodes_only_sampled_frames(tmp_path):
"""End to end over a synthetic clip: load_bytes returns exactly the
sampler's frame count, with the right frame content at each index."""
sampler's frame count, with the right frame content at each index.
"""
pytest.importorskip("cv2")
total_frames, fps = 60, 10
@@ -1742,7 +1745,8 @@ def test_glm5next_backend_decodes_only_sampled_frames(tmp_path):
def test_glm5next_read_frames_seeks_past_large_gaps(tmp_path):
"""Sparse targets must not walk the container: the stock reader grabs
every frame up to the last index; the GLM reader seeks instead."""
every frame up to the last index; the GLM reader seeks instead.
"""
cv2 = pytest.importorskip("cv2")
total_frames, fps = 200, 10
@@ -1769,7 +1773,8 @@ def test_glm5next_read_frames_seeks_past_large_gaps(tmp_path):
def test_glm5next_read_frames_dense_walk_matches_stock(tmp_path):
"""Dense targets keep the sequential walk (seeking would be slower) and
return the same frames as the stock reader."""
return the same frames as the stock reader.
"""
cv2 = pytest.importorskip("cv2")
total_frames, fps = 120, 10