Add pydocstyle to the ruff rules (#52136)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <hej.mellor@gmail.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Harry Mellor
2026-09-16 16:44:29 +00:00
committed by GitHub
co-authored by Claude Opus 5
parent 804e5377aa
commit 8c1557a79c
2002 changed files with 15024 additions and 14269 deletions
@@ -2,7 +2,8 @@
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project
"""Fine-grained partial prefix-cache hits for hybrid (full attention + mamba
"align") models: scheduler chunk splitting, partial tail registration, CoW
on partial hits, and same-step deferral."""
on partial hits, and same-step deferral.
"""
from math import lcm
from types import SimpleNamespace
@@ -174,7 +175,8 @@ def test_mamba_align_split_partial_tail_schedule(dcp_world_size: int):
"""Chunk ends with partial hits on: block-aligned chunks, one extra stop
at the prompt's last hash boundary (registering the partial tail), then
the remaining tokens. block=512, hash=32, prompt=10000, budget=8192:
0 -> 8192 -> 9728 -> 9984 -> 10000."""
0 -> 8192 -> 9728 -> 9984 -> 10000.
"""
block_size = 512
scheduler_block_size = block_size * dcp_world_size
hash_block_size = 32
@@ -742,7 +744,8 @@ def test_hash_aligned_query_end_uses_regular_partial_tail():
def test_external_mamba_hit_same_block_uses_running_cow_on_continue():
"""An external mid-block hit must become a running request even when its
first continuation does not need another Mamba block."""
first continuation does not need another Mamba block.
"""
hash_block_size = 2
mamba_block_size = 4 * hash_block_size
kv_cache_config = KVCacheConfig(
@@ -814,7 +817,8 @@ def test_external_mamba_hit_same_block_uses_running_cow_on_continue():
def test_boundary_state_offloads_returns_cow_target():
"""Boundary hand-offs expose aligned snapshots and the partial-tail CoW
target, never the overwritten CoW source."""
target, never the overwritten CoW source.
"""
hash_block_size = 2
block_size = 2 * hash_block_size
kv_cache_config = KVCacheConfig(
@@ -1000,7 +1004,8 @@ def test_connector_finish_registers_partial_tail_before_cleanup():
def test_boundary_state_offload_dropped_when_request_freed_before_drain():
"""A hand-off recorded in the same scheduling pass as the request's death
must not be drained: its release hook has already run, so draining would
leak a pinned block."""
leak a pinned block.
"""
hash_block_size = 2
block_size = 2 * hash_block_size
kv_cache_config = KVCacheConfig(
@@ -1047,7 +1052,8 @@ def test_boundary_state_offload_dropped_when_request_freed_before_drain():
def test_boundary_state_offloads_block_aligned_prompt():
"""A prompt ending on a block boundary registers no CoW partial tail; its
boundary state block is handed off as a snapshot instead (once)."""
boundary state block is handed off as a snapshot instead (once).
"""
hash_block_size = 2
block_size = 2 * hash_block_size
kv_cache_config = KVCacheConfig(
@@ -1101,7 +1107,8 @@ def test_boundary_state_offloads_block_aligned_prompt():
def test_truncate_computed_blocks_preserves_sparse_prefix_positions():
"""truncate_computed_blocks slices each group by its own block size,
keeps null placeholders in the retained prefix, and leaves the original
lookup result untouched (pure view, no refcount changes)."""
lookup result untouched (pure view, no refcount changes).
"""
hash_block_size = 2
kv_cache_config = KVCacheConfig(
num_blocks=24,
@@ -1156,7 +1163,8 @@ def test_truncate_computed_blocks_preserves_sparse_prefix_positions():
def test_truncate_computed_blocks_allows_short_mamba_group_only():
"""External state may replace a short Mamba hit, but other groups must
cover the aligned local endpoint."""
cover the aligned local endpoint.
"""
hash_block_size = 2
kv_cache_config = KVCacheConfig(
num_blocks=24,
@@ -1298,7 +1306,8 @@ def test_hybrid_mamba_partial_tail_owner_continue_preserves_later_hit():
def test_hybrid_mamba_moved_partial_entry_defers_same_step_hit():
"""The owner's move re-arms the same-step guard: the moved entry is
filled by this step's copy, and chained same-step copies read stale
sources, so a request hitting it in the move step must be deferred."""
sources, so a request hitting it in the move step must be deferred.
"""
hash_block_size = 2
block_size = 2 * hash_block_size
kv_cache_config = KVCacheConfig(
@@ -1588,7 +1597,8 @@ def test_hybrid_partial_hash_truncates_full_attention_hit_length():
def test_cow_retained_blocks_returned_for_release():
"""new_step_starts returns the CoW copy retentions instead of freeing
them; the scheduler owns releasing them once the copy has run."""
them; the scheduler owns releasing them once the copy has run.
"""
hash_block_size = 2
block_size = 2 * hash_block_size
kv_cache_config = KVCacheConfig(
@@ -1641,7 +1651,8 @@ def test_cow_retained_blocks_returned_for_release():
def test_free_cow_retained_blocks_defers_until_copy_step_processed():
"""Scheduler releases CoW retentions immediately when the copy's step has
been processed (or deferral is off), and defers them otherwise."""
been processed (or deferral is off), and defers them otherwise.
"""
from collections import deque
freed: list = []
@@ -1678,7 +1689,8 @@ def test_free_cow_retained_blocks_defers_until_copy_step_processed():
def test_full_attention_eagle_drops_one_hash_unit():
"""With fine-grained partial hits, eagle rewinds the hit by one hash unit
instead of a whole cache block: the tail block's KV is append-only, so it
still covers the reduced length and stays in the hit as a partial block."""
still covers the reduced length and stays in the hit as a partial block.
"""
from vllm.v1.core.block_pool import BlockPool
from vllm.v1.core.single_type_kv_cache_manager import FullAttentionManager
@@ -1754,7 +1766,8 @@ def test_hybrid_partial_hit_with_eagle_stays_within_group_blocks():
"""Regression: with eagle, the mamba group must not receive the eagle
lookup margin — its finder never applies the drop, so it could return a
hit past the blocks the (dropped) full-attention group covers, crashing
the consumer's CoW with block_idx >= len(req_blocks)."""
the consumer's CoW with block_idx >= len(req_blocks).
"""
hash_block_size = 2
block_size = 2 * hash_block_size
kv_cache_config = KVCacheConfig(
@@ -2356,7 +2369,8 @@ def test_retention_snapshots_handed_off_with_exact_block_ids():
"""Under sparse retention, each retained mamba boundary state block is
handed to the connector with its exact block id. Connectors must not resolve
align-mode state blocks positionally because the block table is not
append-only."""
append-only.
"""
hash_block_size = 2
block_size = 4
manager = make_kv_cache_manager(
@@ -2397,7 +2411,8 @@ def test_snapshot_handoff_dense_default_retention():
"""With dense (default) retention, every materialized mamba boundary
state block is handed off — regular mamba-align + prefix-match-unit
deployments get store-able boundary snapshots without setting a
prefix-cache retention interval."""
prefix-cache retention interval.
"""
hash_block_size = 2
block_size = 4
manager = make_kv_cache_manager(
@@ -2429,7 +2444,8 @@ def test_snapshot_handoff_dense_default_retention():
def _run_chunked_prefill(manager, req, chunk_size, num_chunks):
"""Prefill ``req`` one ``chunk_size`` chunk per scheduler step, yielding the
boundary-state hand-offs offered (and claimed) at each step."""
boundary-state hand-offs offered (and claimed) at each step.
"""
computed_blocks, num_computed, _ = manager.get_computed_blocks(req)
for step in range(num_chunks):
manager.new_step_starts()
@@ -2493,7 +2509,8 @@ def test_boundary_states_offered_past_prompt_for_resumed_prefill():
``num_prompt_tokens``. A resumed request re-prefills its generated tokens
and every group re-saves them, so filtering on the original prompt length
would silently strip the mamba key for boundaries full attention still
stores; only the connector knows where its save window ends."""
stores; only the connector knows where its save window ends.
"""
block_size = 8
prompt_len = block_size
manager = make_kv_cache_manager(