[CI][ROCm] Avoid redundant image pulls during smoke validation (#54408)
Signed-off-by: Andreas Karatzas <akaratza@amd.com> Co-authored-by: OpenAI Codex <codex@openai.com>
This commit is contained in:
co-authored by
OpenAI Codex
parent
c28feab989
commit
907b1a7f22
@@ -899,6 +899,17 @@ RUN mkdir src && mv vllm src/vllm
|
||||
# Catch GPU<->CPU syncs in execute_model/sample_tokens during tests.
|
||||
ENV VLLM_GPU_SYNC_CHECK=error
|
||||
|
||||
# Run the structural smoke test inside BuildKit, where the test image layers
|
||||
# are already available. Export only a build-scoped success marker.
|
||||
FROM test AS test_smoke
|
||||
ARG ROCM_SMOKE_ID
|
||||
RUN --network=none \
|
||||
bash /vllm-workspace/.buildkite/scripts/rocm/smoke-test-image.sh --inside \
|
||||
&& printf '%s\n' "${ROCM_SMOKE_ID:-local}" > /vllm-smoke-ok
|
||||
|
||||
FROM scratch AS export_test_smoke
|
||||
COPY --from=test_smoke /vllm-smoke-ok /
|
||||
|
||||
# -----------------------
|
||||
# Final vLLM image
|
||||
FROM mori_base AS final_common
|
||||
|
||||
+17
-1
@@ -281,6 +281,7 @@ target "_ci-rocm" {
|
||||
args = {
|
||||
ARG_PYTORCH_ROCM_ARCH = PYTORCH_ROCM_ARCH
|
||||
CI_BASE_IMAGE = CI_BASE_IMAGE
|
||||
ROCM_SMOKE_ID = BUILDKITE_BUILD_ID
|
||||
max_jobs = CI_MAX_JOBS
|
||||
}
|
||||
}
|
||||
@@ -297,6 +298,15 @@ target "test-rocm-ci" {
|
||||
output = ["type=registry"]
|
||||
}
|
||||
|
||||
# Validate the test image in the shared BuildKit graph and export only the
|
||||
# success marker. This avoids pulling the multi-GB image into the host daemon.
|
||||
target "smoke-test-rocm-ci" {
|
||||
inherits = ["_common-rocm", "_ci-rocm"]
|
||||
target = "export_test_smoke"
|
||||
cache-from = get_cache_from_rocm()
|
||||
output = ["type=local,dest=./build/rocm-smoke-export"]
|
||||
}
|
||||
|
||||
# Cache-only target for the source-scoped ROCm native build stage.
|
||||
# This persists the csrc-build stage in the registry cache even though the
|
||||
# final test image only consumes it indirectly while packaging the wheel.
|
||||
@@ -341,7 +351,13 @@ group "test-rocm-ci-with-artifacts" {
|
||||
# Full test image + wheel export. Kept for fallback/debugging when a pushed,
|
||||
# build-scoped image is useful.
|
||||
group "test-rocm-ci-with-wheel" {
|
||||
targets = ["rust-rocm-ci", "csrc-rocm-ci", "test-rocm-ci", "export-wheel-rocm"]
|
||||
targets = [
|
||||
"rust-rocm-ci",
|
||||
"csrc-rocm-ci",
|
||||
"test-rocm-ci",
|
||||
"smoke-test-rocm-ci",
|
||||
"export-wheel-rocm",
|
||||
]
|
||||
}
|
||||
|
||||
# Primary output tag for the ci_base build. In Buildkite this is a unique,
|
||||
|
||||
Reference in New Issue
Block a user