Preserve revision pins in secondary artifact loaders (#51446)

Signed-off-by: Clinton Thomas <1033162+KernelClint@users.noreply.github.com>
Co-authored-by: Lucas Bourtoule <35483370+dhalf@users.noreply.github.com>
This commit is contained in:
Clinton Thomas
2026-08-11 04:33:10 +00:00
committed by GitHub
co-authored by Lucas Bourtoule
parent adc1200597
commit 90fd4a333f
11 changed files with 226 additions and 13 deletions
+27
View File
@@ -7,6 +7,7 @@ from copy import copy
from pathlib import Path
from types import SimpleNamespace
from typing import cast
from unittest.mock import Mock
import pytest
from transformers import PretrainedConfig
@@ -138,6 +139,32 @@ def test_head_size_falls_back_when_head_dim_is_zero():
assert convertor.get_head_size() == 128
def test_qk_rope_head_dim_recovery_uses_model_revision(monkeypatch: pytest.MonkeyPatch):
hf_config = PretrainedConfig(
model_type="deepseek_v2",
qk_rope_head_dim=128,
qk_nope_head_dim=128,
)
hf_config.name_or_path = "org/model"
get_hf_file_to_dict = Mock(return_value={"qk_rope_head_dim": 64})
monkeypatch.setattr(
"vllm.transformers_utils.repo_utils.get_hf_file_to_dict",
get_hf_file_to_dict,
)
convertor = ModelArchConfigConvertorBase(
hf_config,
hf_config,
revision="pinned-revision",
)
assert convertor._get_qk_rope_head_dim() == 64
get_hf_file_to_dict.assert_called_once_with(
"config.json", "org/model", "pinned-revision"
)
@pytest.mark.parametrize(
"attribute",
[