[Bugfix][Frontend] Malformed $defs in a tool schema should be a 400, not a 500 (#54850)

Signed-off-by: lzhan011 <35493221+lzhan011@users.noreply.github.com>
Signed-off-by: Flora Feng <4florafeng@gmail.com>
Co-authored-by: Flora Feng <4florafeng@gmail.com>
This commit is contained in:
lzhan011
2026-10-06 01:37:20 +00:00
committed by GitHub
co-authored by Flora Feng
parent efd001756b
commit 9bf4e51030
2 changed files with 105 additions and 3 deletions
+10 -3
View File
@@ -368,15 +368,22 @@ def _get_tool_schema_defs(
) -> dict:
all_defs: dict[str, dict[str, Any]] = {}
for tool in tools:
_, params = _extract_tool_info(tool)
name, params = _extract_tool_info(tool)
if params is None:
continue
defs = params.pop("$defs", {})
if not isinstance(defs, dict):
raise VLLMValidationError(
f"`$defs` in the parameters of tool '{name}' must be an "
f"object, got {type(defs).__name__}.",
parameter="tools",
)
for def_name, def_schema in defs.items():
if def_name in all_defs and all_defs[def_name] != def_schema:
raise ValueError(
raise VLLMValidationError(
f"Tool definition '{def_name}' has multiple schemas, "
"which is not supported."
"which is not supported.",
parameter="tools",
)
all_defs[def_name] = def_schema
return all_defs