[Rust Frontend] Record Mooncake/NIXL KV-connector metrics (#52755)

Co-authored-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Markov Ilya <markovilya197@gmail.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
This commit is contained in:
Ilya Markov
2026-09-04 06:21:54 +00:00
committed by GitHub
co-authored by Bugen Zhao
parent 8a728663c1
commit ae2d1ca96f
10 changed files with 600 additions and 62 deletions
@@ -23,6 +23,7 @@ from vllm.distributed.kv_transfer.kv_connector.v1.base import (
from vllm.distributed.kv_transfer.kv_connector.v1.metrics import KVConnectorStats
from vllm.distributed.kv_transfer.kv_connector.v1.multi_connector import (
MultiConnector,
MultiKVConnectorPromMetrics,
MultiKVConnectorStats,
MultiKVConnectorWorkerMetadata,
)
@@ -559,14 +560,12 @@ class TestMultiConnectorStats:
correct data."""
serialized_data = {
"NixlConnector": {
"data": {
"transfer_duration": [1.5, 2.3],
"post_duration": [0.1, 0.2],
"bytes_transferred": [1024, 2048],
"num_descriptors": [10, 20],
"num_failed_transfers": [],
"num_failed_notifications": [],
}
"transfer_duration": [1.5, 2.3],
"post_duration": [0.1, 0.2],
"bytes_transferred": [1024, 2048],
"num_descriptors": [10, 20],
"num_failed_transfers": [],
"num_failed_notifications": [],
}
}
@@ -584,16 +583,14 @@ class TestMultiConnectorStats:
"""Test reconstruction with multiple connector types that have custom stats."""
serialized_data = {
"NixlConnector": {
"data": {
"transfer_duration": [1.5],
"post_duration": [0.1],
"bytes_transferred": [1024],
"num_descriptors": [10],
"num_failed_transfers": [],
"num_failed_notifications": [],
}
"transfer_duration": [1.5],
"post_duration": [0.1],
"bytes_transferred": [1024],
"num_descriptors": [10],
"num_failed_transfers": [],
"num_failed_notifications": [],
},
"MockConnector": {"data": {"mock_field": [1, 2, 3]}},
"MockConnector": {"mock_field": [1, 2, 3]},
}
stats = MultiConnector.build_kv_connector_stats(data=serialized_data)
@@ -608,20 +605,19 @@ class TestMultiConnectorStats:
assert isinstance(stats.data["MockConnector"], MockConnectorStats)
# Verify data is preserved
assert stats.data["MockConnector"].data == {"mock_field": [1, 2, 3]}
assert stats.to_dict() == serialized_data
def test_build_kv_connector_stats_raises_error_for_unknown_connector(self):
"""Test that unknown connectors raise an error."""
serialized_data = {
"UnknownConnector": {"data": {"some_field": [1, 2, 3]}},
"UnknownConnector": {"some_field": [1, 2, 3]},
"NixlConnector": {
"data": {
"transfer_duration": [1.5],
"post_duration": [0.1],
"bytes_transferred": [1024],
"num_descriptors": [10],
"num_failed_transfers": [],
"num_failed_notifications": [],
}
"transfer_duration": [1.5],
"post_duration": [0.1],
"bytes_transferred": [1024],
"num_descriptors": [10],
"num_failed_transfers": [],
"num_failed_notifications": [],
},
}
@@ -675,7 +671,7 @@ class TestMultiConnectorStats:
mixed_data = {
"NixlConnector": nixl_stats, # Already instantiated
"MockConnector": {"data": {"mock_field": [1, 2, 3]}}, # Serialized
"MockConnector": {"mock_field": [1, 2, 3]}, # Serialized
}
stats = MultiConnector.build_kv_connector_stats(data=mixed_data)
@@ -695,16 +691,14 @@ class TestMultiConnectorStats:
# so it returns None and should be skipped
serialized_data = {
"NixlConnector": {
"data": {
"transfer_duration": [1.5],
"post_duration": [0.1],
"bytes_transferred": [1024],
"num_descriptors": [10],
"num_failed_transfers": [],
"num_failed_notifications": [],
}
"transfer_duration": [1.5],
"post_duration": [0.1],
"bytes_transferred": [1024],
"num_descriptors": [10],
"num_failed_transfers": [],
"num_failed_notifications": [],
},
"ExampleConnector": {"data": {"some_field": [1, 2, 3]}},
"ExampleConnector": {"some_field": [1, 2, 3]},
}
stats = MultiConnector.build_kv_connector_stats(data=serialized_data)
@@ -718,14 +712,15 @@ class TestMultiConnectorStats:
# ExampleConnector should be skipped (returns None)
assert "ExampleConnector" not in stats.data
def test_build_kv_connector_stats_handles_malformed_data(self):
"""Test that malformed data raises appropriate errors."""
serialized_data = {
"NixlConnector": {"wrong_field": {"transfer_duration": [1.5]}}
}
def test_prom_metrics_passes_flat_data_to_children(self):
child_metrics = MagicMock()
metrics = object.__new__(MultiKVConnectorPromMetrics)
metrics._prom_metrics = {"NixlConnector": child_metrics}
payload = {"NixlConnector": {"transfer_duration": [1.5]}}
with pytest.raises(AssertionError, match="Expected a dict with a 'data' field"):
MultiConnector.build_kv_connector_stats(data=serialized_data)
metrics.observe(payload, engine_idx=2)
child_metrics.observe.assert_called_once_with({"transfer_duration": [1.5]}, 2)
def test_aggregate_same_connector(self):
"""Test aggregating stats from the same connector type."""
@@ -1709,8 +1709,9 @@ def test_scheduler_kv_connector_stats_aggregation():
final_stats = next(
iter(engine_core_outputs.values())
).scheduler_stats.kv_connector_stats
# The scheduler stats payload carries serialized per-connector dicts.
nixl_stats = final_stats["NixlConnector"]
assert nixl_stats.num_successful_transfers == 2
assert len(nixl_stats["transfer_duration"]) == 2
@pytest.mark.parametrize("distributed_executor_backend", ["ray", None])