[ROCm][Perf] Extend QK-norm/RoPE/KV-cache fusion to MRoPE (#50212)

Signed-off-by: Vorapol Assavasangthong <Vorapol.Assavasangthong@amd.com>
Co-authored-by: Santosh Hiremath <Santosh.Hiremath@amd.com>
Co-authored-by: Douglas Lehr <91553416+dllehr-amd@users.noreply.github.com>
This commit is contained in:
vorapolsiloai
2026-09-23 11:11:57 -05:00
committed by GitHub
co-authored by Santosh Hiremath Douglas Lehr
parent 0549e8d0ab
commit b715699df4
11 changed files with 1314 additions and 118 deletions
@@ -31,6 +31,7 @@ from vllm.platforms import current_platform
ROTARY_OP = torch.ops._C.rotary_embedding.default
FLASHINFER_ROTARY_OP = torch.ops.vllm.flashinfer_rotary_embedding.default
MROPE_OP = torch.ops.vllm.mrope.default
QUANT_OPS: dict[QuantKey, OpOverload] = {
kFp8StaticTensorSym: torch.ops._C.static_scaled_fp8_quant.default, # noqa: E501
@@ -162,6 +163,74 @@ class MatcherRotaryEmbedding(MatcherCustomOp):
return result
class MatcherMRotaryEmbedding(MatcherCustomOp):
def __init__(
self,
is_neox: bool,
head_size: int,
rotary_dim: int,
num_heads: int,
num_kv_heads: int,
mrope_section: tuple[int, int, int],
mrope_interleaved: bool,
enabled: bool | None = None,
) -> None:
if enabled is None:
enabled = RotaryEmbedding.enabled()
super().__init__(enabled)
self.is_neox = is_neox
self.head_size = head_size
self.rotary_dim = rotary_dim
self.num_heads = num_heads
self.num_kv_heads = num_kv_heads
self.q_size = self.num_heads * self.head_size
self.kv_size = self.num_kv_heads * self.head_size
self.mrope_section = mrope_section
self.mrope_interleaved = mrope_interleaved
def inputs(self) -> list[torch.Tensor]:
positions = self.empty_int64(3, 5)
query = self.empty(5, self.q_size)
key = self.empty(5, self.kv_size)
cos_sin_cache = self.empty(4096, self.rotary_dim)
return [positions, query, key, cos_sin_cache]
def forward_custom(
self,
positions: torch.Tensor,
query: torch.Tensor,
key: torch.Tensor,
cos_sin_cache: torch.Tensor,
) -> tuple[torch.Tensor, torch.Tensor]:
result = auto_functionalized(
MROPE_OP,
positions=positions,
query=query,
key=key,
cos_sin_cache=cos_sin_cache,
head_size=self.head_size,
rotary_dim=self.rotary_dim,
mrope_section_t=self.mrope_section[0],
mrope_section_h=self.mrope_section[1],
mrope_section_w=self.mrope_section[2],
mrope_interleaved=self.mrope_interleaved,
is_neox_style=self.is_neox,
)
return result[1], result[2]
def forward_native(
self,
positions: torch.Tensor,
query: torch.Tensor,
key: torch.Tensor,
cos_sin_cache: torch.Tensor,
) -> tuple[torch.Tensor, torch.Tensor]:
raise NotImplementedError(
"MRoPE fusion requires the rotary_embedding custom op"
)
class MatcherRMSNormGated(MatcherCustomOp):
"""Matches RMSNormGated with norm_before_gate=True and group_size=None."""
@@ -2,7 +2,7 @@
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project
import inspect
from collections.abc import Callable
from collections.abc import Callable, Mapping
from typing import ParamSpec
import torch
@@ -19,12 +19,19 @@ from vllm.model_executor.layers.attention.attention import (
Attention,
get_attention_context,
)
from vllm.model_executor.layers.quantization.utils.quant_utils import GroupShape
from vllm.platforms import current_platform
from vllm.utils.torch_utils import direct_register_custom_op
from vllm.utils.torch_utils import (
_USE_LAYERNAME,
LayerNameType,
_encode_layer_name,
_resolve_layer_name,
direct_register_custom_op,
)
from ..inductor_pass import enable_fake_mode
from ..vllm_inductor_pass import VllmInductorPass, VllmPatternMatcherPass
from .matcher_utils import MatcherRotaryEmbedding
from .matcher_utils import MROPE_OP, MatcherMRotaryEmbedding, MatcherRotaryEmbedding
from .rms_quant_fusion import empty_bf16, empty_fp32, empty_i64
logger = init_logger(__name__)
@@ -51,8 +58,9 @@ def fused_qk_norm_rope_and_unified_kv_cache_update_impl(
rms_norm_eps: float,
cos_sin_cache: torch.Tensor,
is_neox: bool,
layer_name: str = "",
layer_name: LayerNameType,
) -> torch.Tensor:
layer_name = _resolve_layer_name(layer_name)
_, attn_layer, kv_cache, layer_slot_mapping = get_attention_context(layer_name)
if layer_slot_mapping is not None:
attn_layer.impl.do_qk_norm_rope_kvcache_update(
@@ -87,7 +95,7 @@ def fused_qk_norm_rope_and_unified_kv_cache_update_fake(
rms_norm_eps: float,
cos_sin_cache: torch.Tensor,
is_neox: bool,
layer_name: str = "",
layer_name: LayerNameType,
) -> torch.Tensor:
return torch.empty(0, device=qkv.device, dtype=qkv.dtype)
@@ -100,6 +108,76 @@ direct_register_custom_op(
)
def fused_qk_norm_mrope_and_unified_kv_cache_update_impl(
q_out: torch.Tensor,
qkv: torch.Tensor,
positions: torch.Tensor,
q_weight: torch.Tensor,
k_weight: torch.Tensor,
rms_norm_eps: float,
cos_sin_cache: torch.Tensor,
is_neox: bool,
mrope_section_t: int,
mrope_section_h: int,
mrope_section_w: int,
is_interleaved: bool,
rotary_dim: int,
layer_name: LayerNameType,
) -> torch.Tensor:
layer_name = _resolve_layer_name(layer_name)
_, attn_layer, kv_cache, layer_slot_mapping = get_attention_context(layer_name)
if layer_slot_mapping is not None:
if positions.ndim == 1:
positions = positions.unsqueeze(0).expand(3, -1).contiguous()
attn_layer.impl.do_qk_norm_mrope_kvcache_update(
attn_layer,
qkv,
q_out,
positions,
q_weight,
k_weight,
rms_norm_eps,
cos_sin_cache,
is_neox,
(mrope_section_t, mrope_section_h, mrope_section_w),
is_interleaved,
rotary_dim,
kv_cache,
layer_slot_mapping,
)
else:
q_out.zero_()
return torch.empty(0, device=qkv.device, dtype=qkv.dtype)
def fused_qk_norm_mrope_and_unified_kv_cache_update_fake(
q_out: torch.Tensor,
qkv: torch.Tensor,
positions: torch.Tensor,
q_weight: torch.Tensor,
k_weight: torch.Tensor,
rms_norm_eps: float,
cos_sin_cache: torch.Tensor,
is_neox: bool,
mrope_section_t: int,
mrope_section_h: int,
mrope_section_w: int,
is_interleaved: bool,
rotary_dim: int,
layer_name: LayerNameType,
) -> torch.Tensor:
return torch.empty(0, device=qkv.device, dtype=qkv.dtype)
direct_register_custom_op(
op_name="fused_qk_norm_mrope_and_unified_kv_cache_update",
op_func=fused_qk_norm_mrope_and_unified_kv_cache_update_impl,
mutates_args=["q_out"],
fake_impl=fused_qk_norm_mrope_and_unified_kv_cache_update_fake,
)
# ---------------------------------------------------------------------------
# Pattern: QK-norm + RoPE + unified_kv_cache_update
# ---------------------------------------------------------------------------
@@ -142,19 +220,27 @@ class QkNormRopeKvCachePattern:
self.eps = eps
self.is_neox = is_neox
self.quant_query = quant_query
self.encoded_layer_name = _encode_layer_name(self.layer_name)
self.query_quant_group_shape = (
layer.query_quant.group_shape
if layer.query_quant is not None
else GroupShape.PER_TENSOR
)
self.q_size = self.num_heads * self.head_size
self.k_size = self.num_kv_heads * self.head_size
self.v_size = self.num_kv_heads * self.head_size_v
self.rope_matcher = MatcherRotaryEmbedding(
is_neox=is_neox,
head_size=self.head_size,
num_heads=self.num_heads,
num_kv_heads=self.num_kv_heads,
self.rope_matcher: MatcherRotaryEmbedding | MatcherMRotaryEmbedding = (
MatcherRotaryEmbedding(
is_neox=is_neox,
head_size=self.head_size,
num_heads=self.num_heads,
num_kv_heads=self.num_kv_heads,
)
)
def get_inputs(self) -> list[torch.Tensor]:
def get_inputs(self) -> list:
T = 5
L = 4096
qkv = empty_bf16(T, self.q_size + self.k_size + self.v_size)
@@ -166,8 +252,13 @@ class QkNormRopeKvCachePattern:
if self.quant_query:
q_scale = empty_fp32(1)
inputs += [q_scale]
if _USE_LAYERNAME:
inputs.append(self.encoded_layer_name)
return inputs
def _get_layer_name(self, layer_name: LayerNameType | None) -> LayerNameType:
return self.encoded_layer_name if layer_name is None else layer_name
def pattern_non_fp8_quant_query(
self,
qkv: torch.Tensor,
@@ -175,6 +266,7 @@ class QkNormRopeKvCachePattern:
q_weight: torch.Tensor,
k_weight: torch.Tensor,
cos_sin_cache: torch.Tensor,
layer_name: LayerNameType | None = None,
) -> tuple[torch.Tensor, torch.Tensor, torch.Tensor, torch.Tensor]:
q, k, v = qkv.split([self.q_size, self.k_size, self.v_size], dim=-1)
q_by_head = q.view(-1, self.q_size // self.head_size, self.head_size)
@@ -190,7 +282,9 @@ class QkNormRopeKvCachePattern:
q_rope = q_rope.view(-1, self.num_heads, self.head_size)
k_rope = k_rope.view(-1, self.num_kv_heads, self.head_size)
v = v.view(-1, self.num_kv_heads, self.head_size_v)
dummy = torch.ops.vllm.unified_kv_cache_update(k_rope, v, self.layer_name)
dummy = torch.ops.vllm.unified_kv_cache_update(
k_rope, v, self._get_layer_name(layer_name)
)
return dummy, q_rope, k_rope, v
def replacement_non_fp8_quant_query(
@@ -200,6 +294,7 @@ class QkNormRopeKvCachePattern:
q_weight: torch.Tensor,
k_weight: torch.Tensor,
cos_sin_cache: torch.Tensor,
layer_name: LayerNameType | None = None,
) -> tuple[torch.Tensor, torch.Tensor, torch.Tensor, torch.Tensor]:
q_out = torch.empty(
qkv.shape[0],
@@ -228,10 +323,49 @@ class QkNormRopeKvCachePattern:
rms_norm_eps=self.eps,
cos_sin_cache=cos_sin_cache,
is_neox=self.is_neox,
layer_name=self.layer_name,
layer_name=self._get_layer_name(layer_name),
)
return results[0], results[1], results[2], v
def _quantize_query(
self,
query: torch.Tensor,
q_scale: torch.Tensor,
) -> tuple[torch.Tensor, torch.Tensor | None]:
if self.query_quant_group_shape.is_per_tensor():
q_out = torch.empty_like(query, dtype=current_platform.fp8_dtype())
q_quant = auto_functionalized(
torch.ops.vllm.rocm_aiter_per_tensor_quant.default,
out=q_out,
x=query,
scale=q_scale,
is_dynamic=False,
)
# The AITER op's schema marks scale mutable, so preserve its
# functionalized write-back as an output of the matched region.
return q_quant[1], q_quant[2]
# QuantFP8.forward_hip falls back to the generic static op for the
# historical per-head shape (-1, block_size). This also covers the
# degenerate one-local-KV-head case where a scalar scale is represented
# as (-1, q_size), rather than changing Attention's classification.
q_out = torch.empty(
query.shape,
device=query.device,
dtype=current_platform.fp8_dtype(),
)
q_quant = auto_functionalized(
torch.ops._C.static_scaled_fp8_quant.default,
result=q_out,
input=query,
scale=q_scale,
group_shape=[
self.query_quant_group_shape.row,
self.query_quant_group_shape.col,
],
)
return q_quant[1], None
def pattern_fp8_quant_query(
self,
qkv: torch.Tensor,
@@ -240,7 +374,8 @@ class QkNormRopeKvCachePattern:
k_weight: torch.Tensor,
cos_sin_cache: torch.Tensor,
q_scale: torch.Tensor,
) -> tuple[torch.Tensor, torch.Tensor, torch.Tensor, torch.Tensor, torch.Tensor]:
layer_name: LayerNameType | None = None,
) -> tuple[torch.Tensor, ...]:
q, k, v = qkv.split([self.q_size, self.k_size, self.v_size], dim=-1)
q_by_head = q.view(-1, self.q_size // self.head_size, self.head_size)
q_normed = vllm.ir.ops.rms_norm(q_by_head, q_weight, self.eps)
@@ -251,24 +386,15 @@ class QkNormRopeKvCachePattern:
k_flat = k_normed.view(-1, self.k_size)
q_rope, k_rope = self.rope_matcher(positions, q_flat, k_flat, cos_sin_cache)
# Match the quant-query op Attention.forward inserts (fp8 KV + UNIFIED).
# Explicit auto_functionalized (out=[1]) keeps the quant node in the pattern.
q_out = torch.empty_like(q_rope, dtype=current_platform.fp8_dtype())
q_quant = auto_functionalized(
torch.ops.vllm.rocm_aiter_per_tensor_quant.default,
out=q_out,
x=q_rope,
scale=q_scale,
is_dynamic=False,
)
# `scale` is mutable: its copy_ write-back to _q_scale bumps the mutation
# region, so keep q flat (a reshape lands past the barrier and won't match).
q_rope_fp8 = q_quant[1]
q_scale_out = q_quant[2]
q_rope_fp8, q_scale_out = self._quantize_query(q_rope, q_scale)
k_rope = k_rope.view(-1, self.num_kv_heads, self.head_size)
v = v.view(-1, self.num_kv_heads, self.head_size_v)
dummy = torch.ops.vllm.unified_kv_cache_update(k_rope, v, self.layer_name)
dummy = torch.ops.vllm.unified_kv_cache_update(
k_rope, v, self._get_layer_name(layer_name)
)
if q_scale_out is None:
return dummy, q_rope_fp8, k_rope, v
return dummy, q_rope_fp8, k_rope, v, q_scale_out
def replacement_fp8_quant_query(
@@ -279,7 +405,8 @@ class QkNormRopeKvCachePattern:
k_weight: torch.Tensor,
cos_sin_cache: torch.Tensor,
q_scale: torch.Tensor,
) -> tuple[torch.Tensor, torch.Tensor, torch.Tensor, torch.Tensor, torch.Tensor]:
layer_name: LayerNameType | None = None,
) -> tuple[torch.Tensor, ...]:
q_out = torch.empty(
qkv.shape[0],
self.num_heads,
@@ -307,22 +434,14 @@ class QkNormRopeKvCachePattern:
rms_norm_eps=self.eps,
cos_sin_cache=cos_sin_cache,
is_neox=self.is_neox,
layer_name=self.layer_name,
layer_name=self._get_layer_name(layer_name),
)
# Re-apply the quant on the kernel's bf16 q_out; fused op does not quant q.
# Same explicit auto_functionalized form as the pattern: [1] = quantized
# q, [2] = scale (returned so the buffer-writeback use is preserved).
# Re-apply the same quant form on the kernel's bf16 q_out; the fused
# operation does not quantize Q.
q_fp8_flat = results[1].view(-1, self.q_size)
q_fp8_out = torch.empty_like(q_fp8_flat, dtype=current_platform.fp8_dtype())
q_requant = auto_functionalized(
torch.ops.vllm.rocm_aiter_per_tensor_quant.default,
out=q_fp8_out,
x=q_fp8_flat,
scale=q_scale,
is_dynamic=False,
)
q_fp8 = q_requant[1] # flat to mirror the pattern (see note above)
q_scale_out = q_requant[2]
q_fp8, q_scale_out = self._quantize_query(q_fp8_flat, q_scale)
if q_scale_out is None:
return results[0], q_fp8, results[2], v
return results[0], q_fp8, results[2], v, q_scale_out
@staticmethod
@@ -345,6 +464,9 @@ class QkNormRopeKvCachePattern:
view_to_reshape(gm)
def _extra_check(self, match: pm.Match) -> bool:
return True
def _register(self, pattern, replacement, pm_pass) -> None:
trace_fn = QkNormRopeKvCachePattern.wrap_trace_fn(
pm.fwd_only,
@@ -370,40 +492,338 @@ class QkNormRopeKvCachePattern:
inputs,
trace_fn,
pm_pass,
extra_check=self._extra_check,
search_fn_pattern=search_fn_pattern,
)
def register(self, pm_pass: PatternMatcherPass) -> None:
# make_fx counts `self` in bound-method code params; wrap as plain fns.
# Distinct names per branch so mypy doesn't see one name, two signatures.
if self.quant_query:
if _USE_LAYERNAME:
def pattern_q(qkv, positions, q_weight, k_weight, cos_sin_cache, q_scale):
return self.pattern_fp8_quant_query(
def pattern_q_with_layer(
qkv,
positions,
q_weight,
k_weight,
cos_sin_cache,
q_scale,
layer_name,
):
return self.pattern_fp8_quant_query(
qkv,
positions,
q_weight,
k_weight,
cos_sin_cache,
q_scale,
layer_name,
)
def replacement_q_with_layer(
qkv,
positions,
q_weight,
k_weight,
cos_sin_cache,
q_scale,
layer_name,
):
return self.replacement_fp8_quant_query(
qkv,
positions,
q_weight,
k_weight,
cos_sin_cache,
q_scale,
layer_name,
)
self._register(pattern_q_with_layer, replacement_q_with_layer, pm_pass)
else:
def pattern_q_without_layer(
qkv, positions, q_weight, k_weight, cos_sin_cache, q_scale
)
):
return self.pattern_fp8_quant_query(
qkv, positions, q_weight, k_weight, cos_sin_cache, q_scale
)
def replacement_q(
qkv, positions, q_weight, k_weight, cos_sin_cache, q_scale
):
return self.replacement_fp8_quant_query(
def replacement_q_without_layer(
qkv, positions, q_weight, k_weight, cos_sin_cache, q_scale
)
):
return self.replacement_fp8_quant_query(
qkv, positions, q_weight, k_weight, cos_sin_cache, q_scale
)
self._register(pattern_q, replacement_q, pm_pass)
self._register(
pattern_q_without_layer, replacement_q_without_layer, pm_pass
)
else:
if _USE_LAYERNAME:
def pattern_noq(qkv, positions, q_weight, k_weight, cos_sin_cache):
return self.pattern_non_fp8_quant_query(
def pattern_noq_with_layer(
qkv,
positions,
q_weight,
k_weight,
cos_sin_cache,
layer_name,
):
return self.pattern_non_fp8_quant_query(
qkv,
positions,
q_weight,
k_weight,
cos_sin_cache,
layer_name,
)
def replacement_noq_with_layer(
qkv,
positions,
q_weight,
k_weight,
cos_sin_cache,
layer_name,
):
return self.replacement_non_fp8_quant_query(
qkv,
positions,
q_weight,
k_weight,
cos_sin_cache,
layer_name,
)
self._register(
pattern_noq_with_layer, replacement_noq_with_layer, pm_pass
)
else:
def pattern_noq_without_layer(
qkv, positions, q_weight, k_weight, cos_sin_cache
):
return self.pattern_non_fp8_quant_query(
qkv, positions, q_weight, k_weight, cos_sin_cache
)
def replacement_noq_without_layer(
qkv, positions, q_weight, k_weight, cos_sin_cache
):
return self.replacement_non_fp8_quant_query(
qkv, positions, q_weight, k_weight, cos_sin_cache
)
self._register(
pattern_noq_without_layer,
replacement_noq_without_layer,
pm_pass,
)
def replacement_noq(qkv, positions, q_weight, k_weight, cos_sin_cache):
return self.replacement_non_fp8_quant_query(
qkv, positions, q_weight, k_weight, cos_sin_cache
)
self._register(pattern_noq, replacement_noq, pm_pass)
class QkNormMRopeKvCachePattern(QkNormRopeKvCachePattern):
FUSED_OP = torch.ops.vllm.fused_qk_norm_mrope_and_unified_kv_cache_update.default
def __init__(
self,
layer: Attention,
eps: float,
is_neox: bool,
quant_query: bool,
rotary_dim: int,
mrope_section: tuple[int, int, int],
is_interleaved: bool,
) -> None:
super().__init__(
layer=layer,
eps=eps,
is_neox=is_neox,
quant_query=quant_query,
)
self.rotary_dim = rotary_dim
self.mrope_section = mrope_section
self.is_interleaved = is_interleaved
self.rope_matcher = MatcherMRotaryEmbedding(
is_neox=is_neox,
head_size=self.head_size,
rotary_dim=rotary_dim,
num_heads=self.num_heads,
num_kv_heads=self.num_kv_heads,
mrope_section=mrope_section,
mrope_interleaved=is_interleaved,
)
def get_inputs(self) -> list[torch.Tensor]:
T = 5
L = 4096
qkv = empty_bf16(T, self.q_size + self.k_size + self.v_size)
positions = empty_i64(3, T)
q_weight = empty_bf16(1, self.head_size)
k_weight = empty_bf16(1, self.head_size)
cos_sin_cache = empty_bf16(L, self.rotary_dim)
inputs = [qkv, positions, q_weight, k_weight, cos_sin_cache]
if self.quant_query:
inputs.append(empty_fp32(1))
if _USE_LAYERNAME:
inputs.append(self.encoded_layer_name)
return inputs
def _unfused_kv_views(self, qkv: torch.Tensor) -> tuple[torch.Tensor, torch.Tensor]:
# The supported backend reads K/V from the cache after the fused write.
# Keep view-compatible placeholders for the attention custom-op ABI.
_, k, v = qkv.split([self.q_size, self.k_size, self.v_size], dim=-1)
k = k.view(qkv.shape[0], self.num_kv_heads, self.head_size)
v = v.view(qkv.shape[0], self.num_kv_heads, self.head_size_v)
return k, v
def _fused_results(
self,
qkv: torch.Tensor,
positions: torch.Tensor,
q_weight: torch.Tensor,
k_weight: torch.Tensor,
cos_sin_cache: torch.Tensor,
layer_name: LayerNameType | None,
) -> tuple[torch.Tensor, ...]:
q_out = torch.empty(
qkv.shape[0],
self.num_heads,
self.head_size,
device=qkv.device,
dtype=qkv.dtype,
)
return auto_functionalized(
self.FUSED_OP,
q_out=q_out,
qkv=qkv,
positions=positions,
q_weight=q_weight,
k_weight=k_weight,
rms_norm_eps=self.eps,
cos_sin_cache=cos_sin_cache,
is_neox=self.is_neox,
mrope_section_t=self.mrope_section[0],
mrope_section_h=self.mrope_section[1],
mrope_section_w=self.mrope_section[2],
is_interleaved=self.is_interleaved,
rotary_dim=self.rotary_dim,
layer_name=self._get_layer_name(layer_name),
)
def replacement_non_fp8_quant_query(
self,
qkv: torch.Tensor,
positions: torch.Tensor,
q_weight: torch.Tensor,
k_weight: torch.Tensor,
cos_sin_cache: torch.Tensor,
layer_name: LayerNameType | None = None,
) -> tuple[torch.Tensor, torch.Tensor, torch.Tensor, torch.Tensor]:
k, v = self._unfused_kv_views(qkv)
results = self._fused_results(
qkv, positions, q_weight, k_weight, cos_sin_cache, layer_name
)
return results[0], results[1], k, v
def replacement_fp8_quant_query(
self,
qkv: torch.Tensor,
positions: torch.Tensor,
q_weight: torch.Tensor,
k_weight: torch.Tensor,
cos_sin_cache: torch.Tensor,
q_scale: torch.Tensor,
layer_name: LayerNameType | None = None,
) -> tuple[torch.Tensor, ...]:
k, v = self._unfused_kv_views(qkv)
results = self._fused_results(
qkv, positions, q_weight, k_weight, cos_sin_cache, layer_name
)
q_flat = results[1].view(-1, self.q_size)
q_fp8, q_scale_out = self._quantize_query(q_flat, q_scale)
if q_scale_out is None:
return results[0], q_fp8, k, v
return results[0], q_fp8, k, v, q_scale_out
def _extra_check(self, match: pm.Match) -> bool:
expected = {
"head_size": self.head_size,
"rotary_dim": self.rotary_dim,
"mrope_section_t": self.mrope_section[0],
"mrope_section_h": self.mrope_section[1],
"mrope_section_w": self.mrope_section[2],
"mrope_interleaved": self.is_interleaved,
"is_neox_style": self.is_neox,
}
mrope_node = next(
(node for node in match.nodes if node.args and node.args[0] == MROPE_OP),
None,
)
if mrope_node is None or any(
mrope_node.kwargs.get(name) != value for name, value in expected.items()
):
return False
# The fused AITER MRoPE entrypoint writes rotated K directly to the
# cache and does not expose a BF16 K result. Returning the raw K view is
# valid only for decoder unified attention, whose backend consumes K
# from that cache. Reject graphs that observe K in any other way.
output_nodes = match.output_nodes()
if len(output_nodes) < 3 or output_nodes[2] is None:
return False
matched_nodes = set(match.nodes)
attention_op = torch.ops.vllm.unified_attention_with_output.default
def is_unified_attention_user(user: fx.Node) -> bool:
return user.op == "call_function" and (
user.target == attention_op
or (user.args and user.args[0] == attention_op)
)
return all(
user in matched_nodes or is_unified_attention_user(user)
for user in output_nodes[2].users
)
def _discover_mrope_configs(
config: VllmConfig,
) -> tuple[tuple[tuple[int, int, int], bool], ...]:
model_config = config.model_config
hf_configs = (
getattr(model_config, "hf_text_config", None),
getattr(model_config, "hf_config", None),
)
configs: set[tuple[tuple[int, int, int], bool]] = set()
for hf_config in hf_configs:
if hf_config is None:
continue
rope_parameters = getattr(hf_config, "rope_parameters", None)
if rope_parameters is None:
rope_parameters = getattr(hf_config, "rope_scaling", None)
if not isinstance(rope_parameters, Mapping):
continue
section = rope_parameters.get("mrope_section")
if not isinstance(section, (list, tuple)) or len(section) != 3:
continue
try:
parsed_section = (
int(section[0]),
int(section[1]),
int(section[2]),
)
except (TypeError, ValueError):
continue
if any(value <= 0 for value in parsed_section):
continue
configs.add(
(
parsed_section,
bool(rope_parameters.get("mrope_interleaved", False)),
)
)
return tuple(sorted(configs))
# ---------------------------------------------------------------------------
@@ -412,7 +832,7 @@ class QkNormRopeKvCachePattern:
class QkNormRopeKvCacheFusionPass(VllmPatternMatcherPass):
"""Fuse QK-norm + RoPE + KV cache update into a single AITER HIP kernel.
"""Fuse QK-norm + RoPE/MRoPE + KV cache update into an AITER HIP kernel.
Supersedes both QKNormRoPEFusionPass and RopeKVCacheFusionPass for
attention layers that support the combined operation, eliminating two
@@ -429,22 +849,33 @@ class QkNormRopeKvCacheFusionPass(VllmPatternMatcherPass):
cc = config.compilation_config
self.max_token_num = cc.pass_config.rope_kvcache_fusion_max_token_num
self.mrope_configs = (
_discover_mrope_configs(config)
if cc.is_custom_op_enabled("rotary_embedding")
else ()
)
dtype = config.model_config.dtype
if dtype not in (torch.bfloat16, torch.float16):
logger.warning_once(
"QK Norm+RoPE+KVCache fusion not enabled: unsupported dtype %s", dtype
"QK Norm+RoPE/MRoPE+KVCache fusion not enabled: unsupported dtype %s",
dtype,
)
return
attn_layers = get_layers_from_vllm_config(config, Attention)
for _, layer in attn_layers.items():
if not layer.impl.fused_qk_norm_rope_kvcache_supported():
supports_rope = layer.impl.fused_qk_norm_rope_kvcache_supported()
supports_mrope = (
bool(self.mrope_configs)
and layer.impl.fused_qk_norm_mrope_kvcache_supported()
)
if not supports_rope and not supports_mrope:
continue
if layer.head_size not in SUPPORTED_FUSED_QK_NORM_ROPE_KVCACHE_HEAD_DIMS:
logger.warning_once(
"QK Norm+RoPE+KVCache fusion not enabled for a layer: "
"QK Norm+RoPE/MRoPE+KVCache fusion not enabled for a layer: "
"head_size=%d is not supported by the "
"fused_qk_norm_rope_cache_pts_quant_shuffle kernel "
"(supported: %s). Falling back to the unfused path.",
@@ -455,22 +886,71 @@ class QkNormRopeKvCacheFusionPass(VllmPatternMatcherPass):
if layer.head_size_v != layer.head_size:
# The fused kernel uses a single head_dim for q/k/v.
logger.warning_once(
"QK Norm+RoPE+KVCache fusion not enabled for a layer: "
"QK Norm+RoPE/MRoPE+KVCache fusion not enabled for a layer: "
"head_size_v=%d differs from head_size=%d, which the fused "
"kernel does not support. Falling back to the unfused path.",
layer.head_size_v,
layer.head_size,
)
continue
for epsilon in [1e-5, 1e-6]:
for neox in [True, False]:
for quant_q in [False, True]:
QkNormRopeKvCachePattern(
layer=layer,
eps=epsilon,
is_neox=neox,
quant_query=quant_q,
).register(self.patterns)
if supports_rope:
for epsilon in [1e-5, 1e-6]:
for neox in [True, False]:
for quant_q in [False, True]:
QkNormRopeKvCachePattern(
layer=layer,
eps=epsilon,
is_neox=neox,
quant_query=quant_q,
).register(self.patterns)
if supports_mrope:
for section, is_interleaved in self.mrope_configs:
rotary_dim = 2 * sum(section)
if rotary_dim > layer.head_size:
logger.warning_once(
"QK Norm+MRoPE+KVCache fusion not enabled for a "
"layer: rotary_dim=%d exceeds head_size=%d.",
rotary_dim,
layer.head_size,
)
continue
vector_width = layer.head_size // 32
for epsilon in [1e-5, 1e-6]:
for neox in [True, False]:
# Each warp lane processes `vector_width` adjacent
# values. NeoX additionally exchanges vectors
# across the half-rotary boundary.
rotary_alignment = vector_width * (2 if neox else 1)
if rotary_dim % rotary_alignment != 0:
logger.warning_once(
"QK Norm+MRoPE+KVCache fusion not enabled "
"for a layer/style: rotary_dim=%d must be "
"divisible by %d for head_size=%d and "
"is_neox=%s.",
rotary_dim,
rotary_alignment,
layer.head_size,
neox,
)
continue
for quant_q in [False, True]:
QkNormMRopeKvCachePattern(
layer=layer,
eps=epsilon,
is_neox=neox,
quant_query=quant_q,
rotary_dim=rotary_dim,
mrope_section=section,
is_interleaved=is_interleaved,
).register(self.patterns)
# Opaque LayerName is a pattern wildcard on torch >= 2.11, so
# homogeneous attention layers produce duplicate search patterns.
# As in the other LayerName-aware fusion passes, one supported
# layer registers all shape/style variants for the model.
if _USE_LAYERNAME:
break
self.dump_patterns(config, self.patterns)
@@ -478,8 +958,8 @@ class QkNormRopeKvCacheFusionPass(VllmPatternMatcherPass):
def __call__(self, graph: fx.Graph) -> None:
self.matched_count = self.patterns.apply(graph)
logger.info(
"QK-Norm+RoPE+KVCache fusion: replaced %s pattern(s) "
"with AITER fused_qk_norm_rope_cache_pts_quant_shuffle",
"QK-Norm+RoPE/MRoPE+KVCache fusion: replaced %s pattern(s) "
"with an AITER fused attention-prologue kernel",
self.matched_count,
)
@@ -487,4 +967,10 @@ class QkNormRopeKvCacheFusionPass(VllmPatternMatcherPass):
return compile_range.end <= self.max_token_num
def uuid(self) -> str:
return VllmInductorPass.hash_source(self, QkNormRopeKvCachePattern)
return VllmInductorPass.hash_source(
self,
QkNormRopeKvCachePattern,
QkNormMRopeKvCachePattern,
_discover_mrope_configs,
repr(self.mrope_configs),
)