From bf049ddb8f4f305cdb01be63f89743f83b397228 Mon Sep 17 00:00:00 2001 From: Jiangyun Zhu Date: Tue, 6 Oct 2026 22:12:18 +0800 Subject: [PATCH] [Docs] Run pr-checklist before opening a PR (#60235) Signed-off-by: zjy0516 Co-authored-by: Claude Opus 5.5 --- .agents/skills/pr-checklist/SKILL.md | 2 +- AGENTS.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.agents/skills/pr-checklist/SKILL.md b/.agents/skills/pr-checklist/SKILL.md index 886e6211a7..4d73be6adf 100644 --- a/.agents/skills/pr-checklist/SKILL.md +++ b/.agents/skills/pr-checklist/SKILL.md @@ -1,6 +1,6 @@ --- name: pr-checklist -description: Prepare a vLLM change for human PR review or re-review, or analyze an open pull request. Use to check design fit, behavioral coverage, performance evidence, diff quality, and closure of previous feedback before requesting maintainer attention. +description: Prepare a vLLM change for human PR review or re-review, or analyze an open pull request. Use before opening a PR, drafts included (e.g. `gh pr create`), or pushing review fixes, to check design fit, behavioral coverage, performance evidence, diff quality, and closure of previous feedback. --- # PR Checklist diff --git a/AGENTS.md b/AGENTS.md index b3ce260383..933fa05cfc 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -31,7 +31,7 @@ Do not open one-off PRs for tiny edits (single typo, isolated style change, one - Test commands run and results. - Model evaluation results when the change affects output, accuracy, or serving. - Clear statement that AI assistance was used. -- Use vLLM's [`/pr-checklist`](.agents/skills/pr-checklist/SKILL.md) skill before submitting a PR to ensure quality and adherence to the contribution guidelines. +- Before opening a PR (drafts included) or requesting re-review, run the [`pr-checklist`](.agents/skills/pr-checklist/SKILL.md) skill and address its findings. ### Fail-closed behavior