From c35551f892f1aa3ace67c0d8cde74eafd00b6e69 Mon Sep 17 00:00:00 2001 From: AlexHuang Date: Tue, 1 Sep 2026 17:24:54 +0800 Subject: [PATCH] [Bugfix][KV Offload] Isolate tiering shutdown failures (#52290) Signed-off-by: Alex Co-authored-by: Or Ozeri --- vllm/v1/kv_offload/tiering/manager.py | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/vllm/v1/kv_offload/tiering/manager.py b/vllm/v1/kv_offload/tiering/manager.py index b2112ae165..8ba23cd83c 100644 --- a/vllm/v1/kv_offload/tiering/manager.py +++ b/vllm/v1/kv_offload/tiering/manager.py @@ -927,7 +927,26 @@ class TieringOffloadingManager(OffloadingManager): @override def shutdown(self) -> None: - """Shutdown all tiers and release resources.""" - for tier in self.secondary_tiers: - tier.shutdown() + """Shut down secondary tiers before releasing primary resources. + + Every secondary tier is given a shutdown attempt. If any shutdown + fails, preserve the primary mmap because a failed tier may still use it. + """ + shutdown_error: Exception | None = None + for tier_idx, tier in enumerate(self.secondary_tiers): + try: + tier.shutdown() + except Exception as exc: + shutdown_error = exc + logger.exception( + "Failed to shut down secondary tier #%d " + "(tier_type=%s, impl_class=%s)", + tier_idx, + tier.tier_type, + type(tier).__name__, + ) + + if shutdown_error is not None: + raise shutdown_error + self.primary_tier.shutdown()