[Mypy] Fix mypy typing for L models (#54177)

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
This commit is contained in:
Taneem Ibrahim
2026-09-04 07:50:43 -04:00
committed by GitHub
parent 3ff4f02dfe
commit c615b1fd67
19 changed files with 255 additions and 89 deletions
+21
View File
@@ -3,6 +3,7 @@
import itertools
import math
import typing
from collections.abc import Iterable, Mapping, Sequence
from typing import Annotated, Any, Literal
@@ -17,6 +18,7 @@ from transformers.models.lfm2_vl.image_processing_lfm2_vl_fast import (
find_closest_aspect_ratio,
round_by_factor,
)
from typing_extensions import Buffer
from vllm.config import VllmConfig
from vllm.config.multimodal import BaseDummyOptions
@@ -229,6 +231,13 @@ class Lfm2VLProcessingInfo(BaseProcessingInfo):
"max_image_tokens", image_processor.max_image_tokens
)
tile_size = mm_kwargs.get("tile_size", image_processor.tile_size)
assert isinstance(downsample_factor, int)
assert isinstance(encoder_patch_size, int)
assert isinstance(max_pixels_tolerance, int | float)
assert isinstance(min_tiles, int)
assert isinstance(max_tiles, int)
assert isinstance(max_image_tokens, int)
assert isinstance(tile_size, int)
do_image_splitting = not min_tiles == max_tiles == 1
is_image_large = self._is_image_too_large(
@@ -337,6 +346,9 @@ class Lfm2VLProcessingInfo(BaseProcessingInfo):
"encoder_patch_size", image_processor.encoder_patch_size
)
tile_size = mm_kwargs.get("tile_size", image_processor.tile_size)
assert isinstance(downsample_factor, int)
assert isinstance(encoder_patch_size, int)
assert isinstance(tile_size, int)
thumbnail_height_patches = int(spatial_shapes[-1][0].item())
thumbnail_width_patches = int(spatial_shapes[-1][1].item())
@@ -672,6 +684,7 @@ class Lfm2VLForConditionalGeneration(
super().__init__()
config: Lfm2VlConfig = vllm_config.model_config.hf_config
multimodal_config = vllm_config.model_config.multimodal_config
assert multimodal_config is not None
vision_config = config.vision_config
quant_config = vllm_config.quant_config
@@ -915,6 +928,14 @@ class Lfm2VLForConditionalGeneration(
"min_image_tokens",
getattr(self.config, "min_image_tokens", None) or 64,
)
if not isinstance(
value,
(str, Buffer, typing.SupportsInt, typing.SupportsIndex),
):
raise TypeError(
"int() argument must be a string, a bytes-like object "
f"or a real number, not '{type(value).__name__}'"
)
return max(1, int(value))
def _get_lfm2vl_item_tile_slices(