[FS-Offloading] Batch Lookup in C (#46713)

Signed-off-by: <>
Co-authored-by: Varun Sundar Rabindranath <varun-sundar-rabindranath@h100-01.nemg-001.lab.rdu2.dc.redhat.com>
This commit is contained in:
Varun Sundar Rabindranath
2026-06-29 09:28:32 -07:00
committed by GitHub
co-authored by Varun Sundar Rabindranath
parent 379acd4e4f
commit c8fb2963bd
5 changed files with 162 additions and 2 deletions
+64 -1
View File
@@ -103,7 +103,7 @@ def lookup_and_wait(
keys: list[OffloadKey],
ctx: ReqContext = _CTX,
timeout: float = 1.0,
) -> list[bool]:
) -> list[LookupResult]:
"""Perform a full async lookup cycle and return resolved results."""
for k in keys:
tier.lookup(k, ctx)
@@ -332,3 +332,66 @@ def test_wait_idle_blocks_until_tasks_complete():
gate.set()
pool.shutdown(wait=True)
waiter.join(timeout=5.0)
def test_batch_lookup_c_extension(tmp_path):
"""Validates batch_lookup_C: empty, single, all-existing, all-missing,
mixed ordering, and input type validation."""
try:
from vllm.fs_io_C import batch_lookup as batch_lookup_C
except ImportError:
pytest.skip("fs_io_C extension not built")
# Setup
all_exist = [str(tmp_path / f"e{i}.bin") for i in range(3)]
for p in all_exist:
open(p, "w").close()
all_missing = [str(tmp_path / f"m{i}.bin") for i in range(3)]
# Empty list
assert batch_lookup_C([]) == []
# Single existing / missing
assert batch_lookup_C([all_exist[0]]) == [True]
assert batch_lookup_C([all_missing[0]]) == [False]
# All existing / all missing
assert batch_lookup_C(all_exist) == [True, True, True]
assert batch_lookup_C(all_missing) == [False, False, False]
# Mixed — verifies index ordering is preserved
paths = [val for pair in zip(all_exist, all_missing) for val in pair]
assert batch_lookup_C(paths) == [True, False, True, False, True, False]
# Input validation: non-list argument
with pytest.raises(TypeError):
batch_lookup_C(("/tmp/foo",))
with pytest.raises(TypeError):
batch_lookup_C(None)
# Input validation: non-str elements in list
with pytest.raises(TypeError):
batch_lookup_C([None])
with pytest.raises(TypeError):
batch_lookup_C([b"/tmp/foo"])
with pytest.raises(TypeError):
batch_lookup_C([42])
with pytest.raises(TypeError):
batch_lookup_C([all_exist[0], None]) # valid first, invalid mid-list
@pytest.mark.parametrize("use_c_ext", [True, False])
def test_batch_lookup_dispatch(fs_tier, monkeypatch, use_c_ext):
import vllm.v1.kv_offload.tiering.fs.manager as mgr_mod
if use_c_ext and not mgr_mod._HAS_BATCH_LOOKUP_C:
pytest.skip("fs_io_C extension not built")
monkeypatch.setattr(mgr_mod, "_HAS_BATCH_LOOKUP_C", use_c_ext)
tier, _ = fs_tier
tier.submit_store(make_job(1, [key(1)], [0]))
assert all(r.success for r in drain(tier))
results = lookup_and_wait(tier, [key(1), key(2)])
assert results == [LookupResult.HIT, LookupResult.MISS]