[feat] Add FP8 per-tensor Q scale support to Triton attention backend (#42080)

Signed-off-by: Dom Brown <3886319+DomBrown@users.noreply.github.com>
This commit is contained in:
Dom Brown
2026-05-19 09:02:05 -07:00
committed by GitHub
parent 8200fbe1ac
commit d247a931cc
3 changed files with 166 additions and 22 deletions
@@ -9,6 +9,7 @@ from vllm.platforms import current_platform
from vllm.utils.math_utils import next_power_of_2
from vllm.utils.torch_utils import set_random_seed
from vllm.v1.attention.ops.triton_unified_attention import unified_attention
from vllm.v1.kv_cache_interface import KVQuantMode
DEVICE_TYPE = current_platform.device_type
@@ -153,16 +154,20 @@ def test_triton_unified_attn(
q_descale = None
k_descale = None
v_descale = None
kv_quant_mode = KVQuantMode.NONE
if q_dtype is not None:
# QKV are drawn from N(0, 1): no need for a fp8 scaling factor
maybe_quantized_query = query.to(q_dtype)
maybe_quantized_key_cache = key_cache.to(q_dtype)
maybe_quantized_value_cache = value_cache.to(q_dtype)
# Use non-1 scales so FP8 Q/K/V descale handling is tested explicitly.
q_scale = torch.tensor(0.75, dtype=torch.float32)
k_scale = torch.tensor(0.5, dtype=torch.float32)
v_scale = torch.tensor(0.25, dtype=torch.float32)
q_descale = q_scale
scale_shape = (num_seqs, num_kv_heads)
q_descale = None # Not yet supported
k_descale = torch.rand(scale_shape, dtype=torch.float32)
v_descale = torch.rand(scale_shape, dtype=torch.float32)
k_descale = torch.full(scale_shape, k_scale.item(), dtype=torch.float32)
v_descale = torch.full(scale_shape, v_scale.item(), dtype=torch.float32)
maybe_quantized_query = (query / q_scale).to(q_dtype)
maybe_quantized_key_cache = (key_cache / k_scale).to(q_dtype)
maybe_quantized_value_cache = (value_cache / v_scale).to(q_dtype)
kv_quant_mode = KVQuantMode.FP8_PER_TENSOR
num_par_softmax_segments = 16
head_size_padded = next_power_of_2(head_size)
@@ -201,6 +206,7 @@ def test_triton_unified_attn(
softmax_segm_output=softmax_segm_output,
softmax_segm_max=softmax_segm_max,
softmax_segm_expsum=softmax_segm_expsum,
kv_quant_mode=kv_quant_mode,
)
ref_output = ref_paged_attn(
@@ -223,6 +229,123 @@ def test_triton_unified_attn(
)
@pytest.mark.parametrize(
"seq_lens", [[(1, 1328), (5, 18), (129, 463)], [(1, 523), (1, 37), (1, 2011)]]
)
@pytest.mark.parametrize("num_heads", NUM_HEADS)
@pytest.mark.parametrize("head_size", HEAD_SIZES)
@pytest.mark.parametrize("block_size", BLOCK_SIZES)
@pytest.mark.parametrize("num_blocks", NUM_BLOCKS)
@pytest.mark.parametrize("seq_threshold_3D", SEQ_THRESHOLD_3D_VALUES)
@torch.inference_mode()
def test_triton_unified_attn_bf16_query_fp8_kv(
seq_lens: list[tuple[int, int]],
num_heads: tuple[int, int],
head_size: int,
block_size: int,
num_blocks: int,
seq_threshold_3D: int,
) -> None:
"""Test bf16 Q with FP8 per-tensor KV cache (dequant via _cast_kv_tile)."""
torch.set_default_device(DEVICE_TYPE)
set_random_seed(0)
num_seqs = len(seq_lens)
query_lens = [x[0] for x in seq_lens]
kv_lens = [x[1] for x in seq_lens]
num_query_heads = num_heads[0]
num_kv_heads = num_heads[1]
assert num_query_heads % num_kv_heads == 0
max_query_len = max(query_lens)
max_kv_len = max(kv_lens)
window_size = (-1, -1)
scale = head_size**-0.5
dtype = torch.bfloat16
query = torch.randn(sum(query_lens), num_query_heads, head_size, dtype=dtype)
key_cache = torch.randn(
num_blocks, block_size, num_kv_heads, head_size, dtype=dtype
)
value_cache = torch.randn_like(key_cache)
k_scale = torch.tensor(0.5, dtype=torch.float32)
v_scale = torch.tensor(0.25, dtype=torch.float32)
fp8_key_cache = (key_cache / k_scale).to(FP8_DTYPE)
fp8_value_cache = (value_cache / v_scale).to(FP8_DTYPE)
scale_shape = (num_seqs, num_kv_heads)
k_descale = torch.full(scale_shape, k_scale.item(), dtype=torch.float32)
v_descale = torch.full(scale_shape, v_scale.item(), dtype=torch.float32)
cu_query_lens = torch.tensor([0] + query_lens, dtype=torch.int32).cumsum(
dim=0, dtype=torch.int32
)
kv_lens_t = torch.tensor(kv_lens, dtype=torch.int32)
max_num_blocks_per_seq = (max_kv_len + block_size - 1) // block_size
block_tables = torch.randint(
0, num_blocks, (num_seqs, max_num_blocks_per_seq), dtype=torch.int32
)
output = torch.empty_like(query)
num_par_softmax_segments = 16
head_size_padded = next_power_of_2(head_size)
softmax_segm_output = torch.empty(
(seq_threshold_3D, num_query_heads, num_par_softmax_segments, head_size_padded),
dtype=torch.float32,
)
softmax_segm_max = torch.empty(
(seq_threshold_3D, num_query_heads, num_par_softmax_segments),
dtype=torch.float32,
)
softmax_segm_expsum = torch.empty(
(seq_threshold_3D, num_query_heads, num_par_softmax_segments),
dtype=torch.float32,
)
unified_attention(
q=query,
k=fp8_key_cache,
v=fp8_value_cache,
out=output,
cu_seqlens_q=cu_query_lens,
seqused_k=kv_lens_t,
max_seqlen_q=max_query_len,
max_seqlen_k=max_kv_len,
softmax_scale=scale,
causal=True,
window_size=window_size,
block_table=block_tables,
softcap=0,
q_descale=None,
k_descale=k_descale,
v_descale=v_descale,
seq_threshold_3D=seq_threshold_3D,
num_par_softmax_segments=num_par_softmax_segments,
softmax_segm_output=softmax_segm_output,
softmax_segm_max=softmax_segm_max,
softmax_segm_expsum=softmax_segm_expsum,
kv_quant_mode=KVQuantMode.FP8_PER_TENSOR,
)
ref_output = ref_paged_attn(
query=query,
key_cache=key_cache,
value_cache=value_cache,
query_lens=query_lens,
kv_lens=kv_lens,
block_tables=block_tables,
scale=scale,
)
atol, rtol = 1.5e-1, 1.5e-1
(
torch.testing.assert_close(output, ref_output, atol=atol, rtol=rtol),
f"{torch.max(torch.abs(output - ref_output))}",
)
@pytest.mark.parametrize(
"seq_lens",
[