[Bugfix][Gemma4] Align parser enable_thinking default with template (#52430)

Signed-off-by: lxy-alexander <lxy_alexander@outlook.com>
Co-authored-by: Chauncey <chaunceyjiang@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This commit is contained in:
Alexander Lee
2026-08-18 12:41:26 +00:00
committed by GitHub
co-authored by Chauncey mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
parent be3f614ff1
commit d29dc3ab87
3 changed files with 31 additions and 9 deletions
@@ -262,14 +262,27 @@ def test_gemma4_adjust_request(generic_tokenizer):
assert result is request
def test_gemma4_previous_turn_reasoning_is_reasoning_end(generic_tokenizer):
@pytest.mark.parametrize(
("chat_template_kwargs", "expected_is_reasoning_end"),
[
pytest.param({}, True, id="omitted_enable_thinking"),
pytest.param({"enable_thinking": False}, True, id="thinking_disabled"),
pytest.param({"enable_thinking": True}, False, id="thinking_enabled"),
],
)
def test_gemma4_new_turn_reasoning_end_matches_enable_thinking(
generic_tokenizer,
chat_template_kwargs,
expected_is_reasoning_end,
):
output = (
"<|channel>thought\n1st thought<channel|>1st content<turn|>\n"
"<|turn>user\nThanks<|turn>model\n"
)
output_tokens = gemma4_encode_output(generic_tokenizer, output)
parser: ReasoningParser = ReasoningParserManager.get_reasoning_parser(parser_name)(
generic_tokenizer
generic_tokenizer,
chat_template_kwargs=chat_template_kwargs,
)
is_reasoning_end = parser.is_reasoning_end(output_tokens)
assert not is_reasoning_end
assert is_reasoning_end is expected_is_reasoning_end