diff --git a/.buildkite/scripts/hardware_ci/run-amd-test.sh b/.buildkite/scripts/hardware_ci/run-amd-test.sh index d07f3b3830..59240b3d0a 100755 --- a/.buildkite/scripts/hardware_ci/run-amd-test.sh +++ b/.buildkite/scripts/hardware_ci/run-amd-test.sh @@ -1712,8 +1712,7 @@ if is_multi_node "$commands"; then # BASH_REMATCH[2] = comma-separated node0 commands # BASH_REMATCH[3] = comma-separated node1 commands if [[ "$commands" =~ ^(.*)\[(.*)"] && ["(.*)\]$ ]]; then - # shellcheck disable=SC2001 # verified equivalent behavior; TODO: switch to param expansion in a follow-up cleanup PR - prefix=$(echo "${BASH_REMATCH[1]}" | sed 's/;//g') + prefix=${BASH_REMATCH[1]//;/} echo "PREFIX: ${prefix}" export composite_command="(command rocm-smi || true)" @@ -1728,10 +1727,8 @@ if is_multi_node "$commands"; then fi for i in "${!node0[@]}"; do - # shellcheck disable=SC2001 # verified equivalent behavior; TODO: switch to param expansion in a follow-up cleanup PR - command_node_0=$(echo "${node0[i]}" | sed 's/\"//g') - # shellcheck disable=SC2001 # verified equivalent behavior; TODO: switch to param expansion in a follow-up cleanup PR - command_node_1=$(echo "${node1[i]}" | sed 's/\"//g') + command_node_0=${node0[i]//\"/} + command_node_1=${node1[i]//\"/} step_cmd="./.buildkite/scripts/run-multi-node-test.sh /vllm-workspace/tests 2 2 ${image_name} '${command_node_0}' '${command_node_1}'" echo "COMMANDS: ${step_cmd}" diff --git a/tools/install_torchcodec_rocm.sh b/tools/install_torchcodec_rocm.sh index e5ce3571f2..d511159ab2 100755 --- a/tools/install_torchcodec_rocm.sh +++ b/tools/install_torchcodec_rocm.sh @@ -117,8 +117,7 @@ echo "Building TorchCodec (MAX_JOBS=$MAX_JOBS)..." pip wheel . --no-build-isolation --no-deps -w "$BUILD_DIR/dist" # Install the built wheel -# shellcheck disable=SC2012 # `ls` sorting is relied on here; TODO: switch to `find` in a follow-up cleanup PR -BUILT_WHEEL=$(ls "$BUILD_DIR/dist"/torchcodec-*.whl 2>/dev/null | head -1) +BUILT_WHEEL=$(find "$BUILD_DIR/dist" -maxdepth 1 -name 'torchcodec-*.whl' -print -quit) if [ -z "$BUILT_WHEEL" ]; then echo "Error: No wheel produced" exit 1 diff --git a/vllm/utils/numa_wrapper.sh b/vllm/utils/numa_wrapper.sh index 3c8b38919c..4f97ebf242 100755 --- a/vllm/utils/numa_wrapper.sh +++ b/vllm/utils/numa_wrapper.sh @@ -15,9 +15,8 @@ if ! command -v numactl >/dev/null 2>&1; then exit 1 fi -# shellcheck disable=SC1001 # verified equivalent behavior; TODO: revisit escaping in a follow-up cleanup PR case "${_VLLM_INTERNAL_NUMACTL_ARGS}" in - *[![:alnum:]\ \-\_=,./]*) + *[![:alnum:]\ _=,./-]*) echo "Invalid characters in _VLLM_INTERNAL_NUMACTL_ARGS" >&2 exit 1 ;;