[Security] Validate cache salts before they reach LMCache (#51444)
Signed-off-by: Clinton Thomas <1033162+KernelClint@users.noreply.github.com> Co-authored-by: Lucas Bourtoule <35483370+dhalf@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
This commit is contained in:
co-authored by
Lucas Bourtoule
Cyrus Leung
parent
4ee2595512
commit
e962733e08
@@ -29,6 +29,28 @@ StopParam: TypeAlias = (
|
||||
str | Annotated[list[str], Field(max_length=envs.VLLM_MAX_STOP_STRINGS)] | None
|
||||
)
|
||||
|
||||
_CACHE_SALT_FORBIDDEN_CHARS = frozenset("@/\\\x00")
|
||||
_MAX_CACHE_SALT_LENGTH = 128
|
||||
|
||||
|
||||
def validate_cache_salt(cache_salt: object) -> None:
|
||||
"""Validate cache salts before they reach downstream cache backends."""
|
||||
if cache_salt is None:
|
||||
return
|
||||
if not isinstance(cache_salt, str) or not cache_salt:
|
||||
raise VLLMValidationError(
|
||||
"Parameter 'cache_salt' must be a non-empty string if provided.",
|
||||
parameter="cache_salt",
|
||||
)
|
||||
if len(cache_salt) > _MAX_CACHE_SALT_LENGTH or any(
|
||||
char in _CACHE_SALT_FORBIDDEN_CHARS for char in cache_salt
|
||||
):
|
||||
raise VLLMValidationError(
|
||||
"Parameter 'cache_salt' must be at most 128 characters and must "
|
||||
"not contain '@', '/', '\\\\', or NUL.",
|
||||
parameter="cache_salt",
|
||||
)
|
||||
|
||||
|
||||
class SpeculativeDecodingMetrics(OpenAIBaseModel):
|
||||
"""Per-request speculative-decoding acceptance metrics.
|
||||
|
||||
Reference in New Issue
Block a user