From ef076c1b7305b1edca58a39bd9922a7286f224d5 Mon Sep 17 00:00:00 2001 From: Nick Hill Date: Thu, 9 Apr 2026 23:34:57 -0700 Subject: [PATCH] [Core] Change max_model_len in EngineCoreReadyResponse to be non-None (#39442) Signed-off-by: Nick Hill --- vllm/v1/engine/__init__.py | 2 +- vllm/v1/engine/core_client.py | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/vllm/v1/engine/__init__.py b/vllm/v1/engine/__init__.py index da26daffdd..c97adfe8f4 100644 --- a/vllm/v1/engine/__init__.py +++ b/vllm/v1/engine/__init__.py @@ -72,9 +72,9 @@ class EngineCoreReadyResponse: values (e.g. max_model_len after KV cache auto-fitting). """ + max_model_len: int num_gpu_blocks: int dp_stats_address: str | None - max_model_len: int | None = None class EngineCoreRequest( diff --git a/vllm/v1/engine/core_client.py b/vllm/v1/engine/core_client.py index 5d170b2171..2f2c15d246 100644 --- a/vllm/v1/engine/core_client.py +++ b/vllm/v1/engine/core_client.py @@ -671,11 +671,9 @@ class MPClient(EngineCoreClient): return vllm_config = self.vllm_config response = msgspec.msgpack.decode(payload, type=EngineCoreReadyResponse) - if response.max_model_len is not None: - vllm_config.model_config.max_model_len = min( - vllm_config.model_config.max_model_len, - response.max_model_len, - ) + vllm_config.model_config.max_model_len = min( + vllm_config.model_config.max_model_len, response.max_model_len + ) # Setup KV cache config with initialization state from # engine core process. Sum values from all engines in DP case.