From f1cf6b0086b95c9594ea685673b9cf8d95ed9b0a Mon Sep 17 00:00:00 2001 From: Nick Hill Date: Wed, 1 Jul 2026 15:00:37 +0100 Subject: [PATCH] [CI] Fix segfault in tracing test (#47299) Signed-off-by: Nick Hill --- tests/v1/tracing/test_tracing.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/v1/tracing/test_tracing.py b/tests/v1/tracing/test_tracing.py index 1b7b243c9d..2b022ffdd9 100644 --- a/tests/v1/tracing/test_tracing.py +++ b/tests/v1/tracing/test_tracing.py @@ -25,11 +25,10 @@ def test_traces( ): with monkeypatch.context() as m: m.setenv(OTEL_EXPORTER_OTLP_TRACES_INSECURE, "true") - if current_platform.is_rocm(): - # The fake OTLP server starts gRPC worker threads before the engine - # core is launched. On ROCm CI, forking while those threads are - # active can segfault in gRPC during engine startup or teardown. - m.setenv("VLLM_WORKER_MULTIPROC_METHOD", "spawn") + # The fake OTLP server starts gRPC worker threads before the engine + # core is launched. gRPC's C-core is not fork-safe and can segfault + # if forked. + m.setenv("VLLM_WORKER_MULTIPROC_METHOD", "spawn") sampling_params = SamplingParams( temperature=0.01,