[Bugfix][Multimodal] Reject malformed base64 audio with 400 instead of 500 (#53744)

Signed-off-by: mhuzaifa3 <mhuzaifa3@outlook.com>
This commit is contained in:
Moe Huzaifa
2026-08-25 17:31:42 +00:00
committed by GitHub
parent 7de96050c5
commit 299ebd094a
2 changed files with 13 additions and 1 deletions
+12
View File
@@ -46,6 +46,18 @@ def test_audio_media_io_load_base64(dummy_audio_bytes):
assert out[1] == 16000
def test_audio_media_io_load_base64_rejects_malformed(dummy_audio_bytes):
"""Malformed base64 must surface as a ValueError so the server answers 400.
Without strict decoding the bad characters are dropped, the garbage reaches
libsndfile, and the client gets a 500 instead."""
encoded = base64.b64encode(dummy_audio_bytes).decode("utf-8")
malformed = encoded[:8] + "!!!@@@###" + encoded[8:]
audio_io = AudioMediaIO()
with pytest.raises(ValueError):
audio_io.load_base64("audio/wav", malformed)
def test_audio_media_io_load_file(audio_assets: AudioTestAssets):
audio_io = AudioMediaIO()
path = audio_assets[0].get_local_path()
+1 -1
View File
@@ -309,7 +309,7 @@ class AudioMediaIO(MediaIO[tuple[npt.NDArray, float]]):
parameter="audio_filesize_mb",
value=(len(data) * 3 / 4) / MiB_bytes,
)
return self.load_bytes(pybase64.b64decode(data))
return self.load_bytes(pybase64.b64decode(data, validate=True))
def load_file(self, filepath: Path) -> tuple[npt.NDArray, float]:
self._validate_encoded_size(filepath.stat().st_size)